public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
* Re: DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?]
@ 2003-03-03 20:00 Michael Elizabeth Chastain
  2003-03-03 20:05 ` Daniel Jacobowitz
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Elizabeth Chastain @ 2003-03-03 20:00 UTC (permalink / raw)
  To: drow, gdb

About this patch for the dejagnu droppings:

  --- src/dejagnu/Makefile.am	2002-04-21 04:46:47.000000000 -0400
  +++ tsrc/dejagnu/Makefile.am	2002-11-20 16:35:17.000000000 -0500
  @@ -34,10 +34,13 @@
   # We don't use SUBDIRS, so the excample or test cases don't get built
   # by default for a "make all".
   clean-local:
  -	cd doc       ; $(MAKE) clean
	  cd testsuite ; $(MAKE) clean
	  cd example   ; $(MAKE) clean
   
  +distclean-local:
  +	cd testsuite ; $(MAKE) distclean
  +	cd example   ; $(MAKE) distclean
  +

I started down this path, but it needs more work.  The problem is
that dejagnu/example/calc/Makefile.in does not remove config.status
when it does a distclean.  I tried regenerating this file from
dejagnu/example/calc/Makefile.am, but various versions of automake
gave me attitude in various ways.

Now my plan is:

  (1) read the autoconf/automake/libtool book
  (2) do a big cleanup in cvs dejagnu
  (3) import to sourceware

But that's going to take a while, so I'm going to fall back and do
something cheap so that our tarballs work.  Probably revive this patch:

  revision 1.2
  date: 2000/04/19 02:28:55;  author: cagney;  state: Exp;  lines: +1 -1
  Add directory example to SUBDIRS.

That worked for two years and then got overwritten by an import.

Michael C

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?]
  2003-03-03 20:00 DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?] Michael Elizabeth Chastain
@ 2003-03-03 20:05 ` Daniel Jacobowitz
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-03-03 20:05 UTC (permalink / raw)
  To: Michael Elizabeth Chastain; +Cc: gdb

On Mon, Mar 03, 2003 at 02:00:28PM -0600, Michael Elizabeth Chastain wrote:
> About this patch for the dejagnu droppings:
> 
>   --- src/dejagnu/Makefile.am	2002-04-21 04:46:47.000000000 -0400
>   +++ tsrc/dejagnu/Makefile.am	2002-11-20 16:35:17.000000000 -0500
>   @@ -34,10 +34,13 @@
>    # We don't use SUBDIRS, so the excample or test cases don't get built
>    # by default for a "make all".
>    clean-local:
>   -	cd doc       ; $(MAKE) clean
> 	  cd testsuite ; $(MAKE) clean
> 	  cd example   ; $(MAKE) clean
>    
>   +distclean-local:
>   +	cd testsuite ; $(MAKE) distclean
>   +	cd example   ; $(MAKE) distclean
>   +
> 
> I started down this path, but it needs more work.  The problem is
> that dejagnu/example/calc/Makefile.in does not remove config.status
> when it does a distclean.  I tried regenerating this file from
> dejagnu/example/calc/Makefile.am, but various versions of automake
> gave me attitude in various ways.

Try "automake --foreign" in the example/calc/ directory.  The version
of automake that I have installed generates a makefile which removes
config.status properly.  So does the snapshot from sourceware. 
Regenerating it is all it takes.

> 
> Now my plan is:
> 
>   (1) read the autoconf/automake/libtool book
>   (2) do a big cleanup in cvs dejagnu
>   (3) import to sourceware

I don't think a "big" cleanup is called for.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?]
  2003-03-03 20:50 Michael Elizabeth Chastain
@ 2003-03-03 20:55 ` Daniel Jacobowitz
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-03-03 20:55 UTC (permalink / raw)
  To: Michael Elizabeth Chastain; +Cc: gdb

On Mon, Mar 03, 2003 at 02:50:25PM -0600, Michael Elizabeth Chastain wrote:
> Hi Daniel,
> 
> > Try "automake --foreign" in the example/calc/ directory.  The version
> > of automake that I have installed generates a makefile which removes
> > config.status properly.  So does the snapshot from sourceware. 
> > Regenerating it is all it takes.
> 
> That sounds like it will fix my problem.
> 
> > I don't think a "big" cleanup is called for.
> 
> I do.  dejagnu currently has a custom *TCL* script to help with the
> cleanup.  There's gotta be some good cleanup opportunities in there.
> 
> I don't think gdb needs that cleanup to happen, though.  It would
> just be for dejagnu's benefit.

That's only used in preparing DejaGNU tarballs, so GDB definitely
doesn't care...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?]
@ 2003-03-03 20:50 Michael Elizabeth Chastain
  2003-03-03 20:55 ` Daniel Jacobowitz
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Elizabeth Chastain @ 2003-03-03 20:50 UTC (permalink / raw)
  To: drow; +Cc: gdb

Hi Daniel,

> Try "automake --foreign" in the example/calc/ directory.  The version
> of automake that I have installed generates a makefile which removes
> config.status properly.  So does the snapshot from sourceware. 
> Regenerating it is all it takes.

That sounds like it will fix my problem.

> I don't think a "big" cleanup is called for.

I do.  dejagnu currently has a custom *TCL* script to help with the
cleanup.  There's gotta be some good cleanup opportunities in there.

I don't think gdb needs that cleanup to happen, though.  It would
just be for dejagnu's benefit.

Michael C

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?]
@ 2003-03-03 14:47 Michael Elizabeth Chastain
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Elizabeth Chastain @ 2003-03-03 14:47 UTC (permalink / raw)
  To: drow, gdb

Yeah, that's the same problem (PR gdb/708), and the same patch that
I have: add a distclean-local goal to Makefile.am.

I am working on this as a prospective dejagnu contributor now,
so I want to dig a little deeper.  dejagnu has a lot of crap in
their configure/automake/make-distribution logic, such as a
custom TCL script to do cleaning!

My plan is to cuddle up with the autoconf/automake/libtool book
and then clean up CVS dejagnu and then do an import.  We can do
something faster in sourceware if we want, either the 'distclean-local'
idea or Andrew's earlier local fix from 2000, which is even simpler:
add 'example' and 'testsuite' to the SUBDIRS list in Makefile.am.

Michael C

^ permalink raw reply	[flat|nested] 6+ messages in thread

* DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?]
@ 2003-03-03  3:55 Daniel Jacobowitz
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2003-03-03  3:55 UTC (permalink / raw)
  To: gdb, mec

Hey, Michael, is this what you had in mind for DejaGNU?  Found it going
through my mailboxes tonight.

----- Forwarded message from Daniel Jacobowitz <drow@mvista.com> -----

Date: Wed, 20 Nov 2002 16:41:12 -0500
From: Daniel Jacobowitz <drow@mvista.com>
Subject: Re: [5.3] What's the hold up?
To: Andrew Cagney <ac131313@redhat.com>, gdb@sources.redhat.com
Mail-Followup-To: Andrew Cagney <ac131313@redhat.com>,
	gdb@sources.redhat.com

On Wed, Nov 20, 2002 at 02:07:05PM -0500, Daniel Jacobowitz wrote:
> On Wed, Nov 20, 2002 at 01:52:27PM -0500, Daniel Jacobowitz wrote:
> > On Wed, Nov 20, 2002 at 12:50:46PM -0500, Andrew Cagney wrote:
> > > If you search the bug data base for high GDB PR's you'll see:
> > > 
> > > PR Category State Priority Responsible Synopsis
> > > 378 gdb suspended high unassigned ``GNU/Linux'' ``Linux kernel''
> > > 394 gdb suspended high unassigned GDB 5.1.1 contains intl/ droppings
> > > 527 gdb suspended high unassigned GDB 5.2 incompatibilities with GNU 
> > > textutils 2.0.21 in POSIX mode
> > > 676 gdb analyzed high unassigned Alpha OSF1, gcc, internal GDB error in 
> > > mdebugread
> > > 708 gdb open high unassigned Can't build 5.3 branch (and probably trunk).
> > > 725 gdb open high unassigned Crash using debug target and regcaches (in 
> > > 5.3 branch?)
> > > 763 gdb open high unassigned gdb 5.2 removes the conditional breakpoints
> > > 840 gdb suspended high unassigned Expect on GDB 5.3 branch doesn't build 
> > > on IRIX 6.5
> > > 
> > > It is these (actually the non-suspended ones) that I'm trying to get 
> > > flushed.
> > > 
> > > Of most concern are 708 and 676.  They both indicate something failing the:
> > > 
> > > 	./configure
> > > 	make
> > > 	./gdb/gdb ./gdb/gdb
> > > 	(gdb) b main
> > > 	(gdb) run
> > > 
> > > release criteria :-(
> > 
> > I hit gdb/708 on HP/UX... it's really not that complicated to fix, I
> > don't think...
> > 
> > Of course trying to reproduce it I can't even build the snapshot; it
> > tries to make distclean in itcl.
> 
> However, my guess at a fix for gdb/708 is that dejagnu/Makefile.am
> needs a distclean-local to parallel clean-local, which distcleans in
> example/.
> 
> The failure in itcl/ appears to be a configure script bug with autoconf
> 2.5.  Keith fixed this on mainline on Sep. 5th:
> 
>         * configure.in (subdirs): New variable. Don't put AC_CONFIG_SUBDIRS
>         macro into configure.in twice: it confuses autoconf. Instead use
>         the variable to hold the subdirs to be configured.
>         * configure: Regenerated.
> 
> This should probably go to the branch.

It did, two months ago.  I haven't cvs up'd that tree in longer than I
had thought :)

Try this patch for the DejaGNU droppings.  And one in gdb/doc/.  That
wasn't so hard, was it?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

--- src/gdb/doc/Makefile.in	2002-11-20 15:48:51.000000000 -0500
+++ tsrc/gdb/doc/Makefile.in	2002-11-20 15:57:21.000000000 -0500
@@ -423,7 +423,7 @@
 	rm -f gdb-cfg.texi
 
 distclean: clean
-	rm -f Makefile config.status
+	rm -f Makefile config.status config.log
 
 # GDBvn.texi, the dvi files, the info files, and the postscript files, 
 # are all part of the distribution, so it should not be removed by
--- src/dejagnu/Makefile.am	2002-04-21 04:46:47.000000000 -0400
+++ tsrc/dejagnu/Makefile.am	2002-11-20 16:35:17.000000000 -0500
@@ -34,10 +34,13 @@
 # We don't use SUBDIRS, so the excample or test cases don't get built
 # by default for a "make all".
 clean-local:
-	cd doc       ; $(MAKE) clean
 	cd testsuite ; $(MAKE) clean
 	cd example   ; $(MAKE) clean
 
+distclean-local:
+	cd testsuite ; $(MAKE) distclean
+	cd example   ; $(MAKE) distclean
+
 # Set ourselves up to build a RedHat package
 tarball: overview.html overview.ps overview.pdf
 	-rm -fr dejagnu-${VERSION}
--- src/dejagnu/Makefile.in	2002-09-02 07:53:24.000000000 -0400
+++ tsrc/dejagnu/Makefile.in	2002-11-20 16:35:31.000000000 -0500
@@ -1,6 +1,6 @@
-# Makefile.in generated automatically by automake 1.4-p5 from Makefile.am
+# Makefile.in generated automatically by automake 1.4 from Makefile.am
 
-# Copyright (C) 1994, 1995-8, 1999, 2001 Free Software Foundation, Inc.
+# Copyright (C) 1994, 1995-8, 1999 Free Software Foundation, Inc.
 # This Makefile.in is free software; the Free Software Foundation
 # gives unlimited permission to copy and/or distribute it,
 # with or without modifications, as long as this notice is preserved.
@@ -123,7 +123,7 @@
 
 DISTFILES = $(DIST_COMMON) $(SOURCES) $(HEADERS) $(TEXINFOS) $(EXTRA_DIST)
 
-TAR = gtar
+TAR = tar
 GZIP_ENV = --best
 EXPECT = expect
 all: all-redirect
@@ -236,7 +236,7 @@
 	dot_seen=no; \
 	rev=''; list='$(SUBDIRS)'; for subdir in $$list; do \
 	  rev="$$subdir $$rev"; \
-	  test "$$subdir" != "." || dot_seen=yes; \
+	  test "$$subdir" = "." && dot_seen=yes; \
 	done; \
 	test "$$dot_seen" = "no" && rev=". $$rev"; \
 	target=`echo $@ | sed s/-recursive//`; \
@@ -406,7 +406,7 @@
 
 clean: clean-recursive
 
-distclean-am:  distclean-tags distclean-generic clean-am
+distclean-am:  distclean-tags distclean-generic clean-am distclean-local
 
 distclean: distclean-recursive
 	-rm -f config.status
@@ -443,10 +443,13 @@
 # We don't use SUBDIRS, so the excample or test cases don't get built
 # by default for a "make all".
 clean-local:
-	cd doc       ; $(MAKE) clean
 	cd testsuite ; $(MAKE) clean
 	cd example   ; $(MAKE) clean
 
+distclean-local:
+	cd testsuite ; $(MAKE) distclean
+	cd example   ; $(MAKE) distclean
+
 # Set ourselves up to build a RedHat package
 tarball: overview.html overview.ps overview.pdf
 	-rm -fr dejagnu-${VERSION}


----- End forwarded message -----

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2003-03-03 20:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-03 20:00 DejaGNU vs snapshots [drow@mvista.com: Re: [5.3] What's the hold up?] Michael Elizabeth Chastain
2003-03-03 20:05 ` Daniel Jacobowitz
  -- strict thread matches above, loose matches on Subject: below --
2003-03-03 20:50 Michael Elizabeth Chastain
2003-03-03 20:55 ` Daniel Jacobowitz
2003-03-03 14:47 Michael Elizabeth Chastain
2003-03-03  3:55 Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).