removes trivial compilation warning

removes trivial compilation warning

[Joerg Beyer]

This fixes a trivial warning:

gdb/gdbserver/gdbreplay.c gives a warning, because atoi is
not declared. The inlcude of stdlib.h fixes this:

    Joerg

diff -c src_orig/gdb/gdbserver/gdbreplay.c src/gdb/gdbserver/gdbreplay.c
*** src_orig/gdb/gdbserver/gdbreplay.c  2002-07-09 19:38:58.000000000 +0200
--- src/gdb/gdbserver/gdbreplay.c       2003-03-17 19:53:38.000000000 +0100
***************
*** 30,35 ****
--- 30,36 ----
  #include <ctype.h>
  #include <fcntl.h>
  #include <errno.h>
+ #include <stdlib.h>

  #ifdef HAVE_STDLIB_H
  #include <stdlib.h> 

Re: removes trivial compilation warning

[Daniel Jacobowitz]

On Mon, Mar 17, 2003 at 08:19:38PM +0100, Joerg Beyer wrote:
> This fixes a trivial warning:
> 
> gdb/gdbserver/gdbreplay.c gives a warning, because atoi is
> not declared. The inlcude of stdlib.h fixes this:
> 
>     Joerg
> 
> diff -c src_orig/gdb/gdbserver/gdbreplay.c src/gdb/gdbserver/gdbreplay.c
> *** src_orig/gdb/gdbserver/gdbreplay.c  2002-07-09 19:38:58.000000000 +0200
> --- src/gdb/gdbserver/gdbreplay.c       2003-03-17 19:53:38.000000000 +0100
> ***************
> *** 30,35 ****
> --- 30,36 ----
>   #include <ctype.h>
>   #include <fcntl.h>
>   #include <errno.h>
> + #include <stdlib.h>
> 
>   #ifdef HAVE_STDLIB_H
>   #include <stdlib.h> 

Look down a line in your patch.  Is HAVE_STDLIB_H not getting defined?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: removes trivial compilation warning

[Daniel Jacobowitz]

On Mon, Mar 17, 2003 at 02:36:03PM -0500, Daniel Jacobowitz wrote:
> On Mon, Mar 17, 2003 at 08:19:38PM +0100, Joerg Beyer wrote:
> > This fixes a trivial warning:
> > 
> > gdb/gdbserver/gdbreplay.c gives a warning, because atoi is
> > not declared. The inlcude of stdlib.h fixes this:
> > 
> >     Joerg
> > 
> > diff -c src_orig/gdb/gdbserver/gdbreplay.c src/gdb/gdbserver/gdbreplay.c
> > *** src_orig/gdb/gdbserver/gdbreplay.c  2002-07-09 19:38:58.000000000 +0200
> > --- src/gdb/gdbserver/gdbreplay.c       2003-03-17 19:53:38.000000000 +0100
> > ***************
> > *** 30,35 ****
> > --- 30,36 ----
> >   #include <ctype.h>
> >   #include <fcntl.h>
> >   #include <errno.h>
> > + #include <stdlib.h>
> > 
> >   #ifdef HAVE_STDLIB_H
> >   #include <stdlib.h> 
> 
> Look down a line in your patch.  Is HAVE_STDLIB_H not getting defined?

No, it wasn't.  I've fixed this in CVS.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: removes trivial compilation warning

[Joerg Beyer]

Daniel Jacobowitz wrote:
> Look down a line in your patch.  Is HAVE_STDLIB_H not getting defined?
> 
OK :-)

the configure.in in the gdbserver directory does not check for for stdlib (but use the HAVE_STDLIB_H as seen above).

gdbreplay.c include the local config.h (in the gdbserver directory), so
there is no define HAVE_STDLIB_H 

In the directory above this, the check is there, it this one: 
AC_CHECK_HEADERS(stdlib.h)

As far as I can see the configure in gdb/gdbserver
dont use other configure results (e.g. by including ../config.h),
so I suggest to extend the AC_CHECK_HEADERS to check also                       for stdlib in gdb/gdbserver/configure.in 

Of course my patch was bullshit :-)

    Joerg