* Re: removes trivial compilation warning
@ 2003-03-17 20:47 Joerg Beyer
0 siblings, 0 replies; 4+ messages in thread
From: Joerg Beyer @ 2003-03-17 20:47 UTC (permalink / raw)
To: drow; +Cc: gdb
Daniel Jacobowitz wrote:
> Look down a line in your patch. Is HAVE_STDLIB_H not getting defined?
>
OK :-)
the configure.in in the gdbserver directory does not check for for stdlib (but use the HAVE_STDLIB_H as seen above).
gdbreplay.c include the local config.h (in the gdbserver directory), so
there is no define HAVE_STDLIB_H
In the directory above this, the check is there, it this one:
AC_CHECK_HEADERS(stdlib.h)
As far as I can see the configure in gdb/gdbserver
dont use other configure results (e.g. by including ../config.h),
so I suggest to extend the AC_CHECK_HEADERS to check also for stdlib in gdb/gdbserver/configure.in
Of course my patch was bullshit :-)
Joerg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: removes trivial compilation warning
2003-03-17 19:36 ` Daniel Jacobowitz
@ 2003-03-17 19:41 ` Daniel Jacobowitz
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2003-03-17 19:41 UTC (permalink / raw)
To: Joerg Beyer, gdb
On Mon, Mar 17, 2003 at 02:36:03PM -0500, Daniel Jacobowitz wrote:
> On Mon, Mar 17, 2003 at 08:19:38PM +0100, Joerg Beyer wrote:
> > This fixes a trivial warning:
> >
> > gdb/gdbserver/gdbreplay.c gives a warning, because atoi is
> > not declared. The inlcude of stdlib.h fixes this:
> >
> > Joerg
> >
> > diff -c src_orig/gdb/gdbserver/gdbreplay.c src/gdb/gdbserver/gdbreplay.c
> > *** src_orig/gdb/gdbserver/gdbreplay.c 2002-07-09 19:38:58.000000000 +0200
> > --- src/gdb/gdbserver/gdbreplay.c 2003-03-17 19:53:38.000000000 +0100
> > ***************
> > *** 30,35 ****
> > --- 30,36 ----
> > #include <ctype.h>
> > #include <fcntl.h>
> > #include <errno.h>
> > + #include <stdlib.h>
> >
> > #ifdef HAVE_STDLIB_H
> > #include <stdlib.h>
>
> Look down a line in your patch. Is HAVE_STDLIB_H not getting defined?
No, it wasn't. I've fixed this in CVS.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: removes trivial compilation warning
2003-03-17 19:19 Joerg Beyer
@ 2003-03-17 19:36 ` Daniel Jacobowitz
2003-03-17 19:41 ` Daniel Jacobowitz
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Jacobowitz @ 2003-03-17 19:36 UTC (permalink / raw)
To: Joerg Beyer; +Cc: gdb
On Mon, Mar 17, 2003 at 08:19:38PM +0100, Joerg Beyer wrote:
> This fixes a trivial warning:
>
> gdb/gdbserver/gdbreplay.c gives a warning, because atoi is
> not declared. The inlcude of stdlib.h fixes this:
>
> Joerg
>
> diff -c src_orig/gdb/gdbserver/gdbreplay.c src/gdb/gdbserver/gdbreplay.c
> *** src_orig/gdb/gdbserver/gdbreplay.c 2002-07-09 19:38:58.000000000 +0200
> --- src/gdb/gdbserver/gdbreplay.c 2003-03-17 19:53:38.000000000 +0100
> ***************
> *** 30,35 ****
> --- 30,36 ----
> #include <ctype.h>
> #include <fcntl.h>
> #include <errno.h>
> + #include <stdlib.h>
>
> #ifdef HAVE_STDLIB_H
> #include <stdlib.h>
Look down a line in your patch. Is HAVE_STDLIB_H not getting defined?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 4+ messages in thread
* removes trivial compilation warning
@ 2003-03-17 19:19 Joerg Beyer
2003-03-17 19:36 ` Daniel Jacobowitz
0 siblings, 1 reply; 4+ messages in thread
From: Joerg Beyer @ 2003-03-17 19:19 UTC (permalink / raw)
To: gdb
This fixes a trivial warning:
gdb/gdbserver/gdbreplay.c gives a warning, because atoi is
not declared. The inlcude of stdlib.h fixes this:
Joerg
diff -c src_orig/gdb/gdbserver/gdbreplay.c src/gdb/gdbserver/gdbreplay.c
*** src_orig/gdb/gdbserver/gdbreplay.c 2002-07-09 19:38:58.000000000 +0200
--- src/gdb/gdbserver/gdbreplay.c 2003-03-17 19:53:38.000000000 +0100
***************
*** 30,35 ****
--- 30,36 ----
#include <ctype.h>
#include <fcntl.h>
#include <errno.h>
+ #include <stdlib.h>
#ifdef HAVE_STDLIB_H
#include <stdlib.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-03-17 20:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-17 20:47 removes trivial compilation warning Joerg Beyer
-- strict thread matches above, loose matches on Subject: below --
2003-03-17 19:19 Joerg Beyer
2003-03-17 19:36 ` Daniel Jacobowitz
2003-03-17 19:41 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).