Re: objc-lang.c portability (Was Re: [PATCH] Step over Objective-C dispatch function)

[Daniel Jacobowitz <drow@mvista.com>]

On Wed, Mar 26, 2003 at 04:31:23PM -0700, Adam Fedor wrote:
> 
> On Thursday, March 20, 2003, at 02:08 PM, Andrew Cagney wrote:
> >
> >I've looked at what the underlying code is trying to do and, 
> >unfortunatly, the original objc-lang.c botched its portability(1), 
> >sigh!  The file is currently native only so infrun.c can't directly 
> >refer to objc-lang.c, and hence, will need to go via a dispatch table. 
> > Going via a dispatch table wouldn't hurt anyway.
> >
> >(1) I noticed that the parameter extract methods assume host=target.
> >
> 
> I'm wondering what's not portable with objc-lang.c? With the remaining 
> patches I have that require this, I was thinking it might be easier to 
> just fix it now. The alternative appears to be adding a whole bunch of 
> things to the language_defn structure. I admit I don't really 
> understand the problem though.

At the very least FETCH_ARGUMENT and CONVERT_FUNCPTR need to go into
the architecture vector.  They're completely incorrect:
  - they assume host == target
  - they will prevent GDB from compiling on host !< {i386, ppc, sparc, hppa}

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer