public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb@sources.redhat.com
Subject: Re: Problem with virtual function pointers
Date: Thu, 27 Mar 2003 16:18:00 -0000	[thread overview]
Message-ID: <20030327161824.GM23762@cygbert.vinschen.de> (raw)
In-Reply-To: <20030327152652.GA8010@nevyn.them.org>

On Thu, Mar 27, 2003 at 10:26:52AM -0500, Daniel Jacobowitz wrote:
> There's your bug, right on schedule.  Look at the line:
>   addr = unpack_pointer (lookup_pointer_type (builtin_type_void), valaddr);
> 
> Recommend using builtin_type_void_func_ptr instead of
> lookup_pointer_type (builtin_type_void).  Does that fix it?

Yes, it does fix the problem.  Thank you!

However, I don't understand why it's done this way.  The incoming
type into this function is already correct AFAICS (well, this time,
I didn't get it when I wrote my first posting, apparently).  type
is a TYPE_CODE_PTR to a TYPE_CODE_METHOD to TYPE_CODE_VOID.

So, from my point of view the correct call would just be

  addr = unpack_pointer (type, valaddr);

Why isn't type just used as is?

Btw., I've just ran the full c++ testsuite again and using just type shows
no regressions (for xstormy16).


Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

  reply	other threads:[~2003-03-27 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-27 14:24 Corinna Vinschen
2003-03-27 14:53 ` Daniel Jacobowitz
2003-03-27 15:20   ` Corinna Vinschen
2003-03-27 15:26     ` Daniel Jacobowitz
2003-03-27 16:18       ` Corinna Vinschen [this message]
2003-04-01 17:34         ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030327161824.GM23762@cygbert.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).