From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25053 invoked by alias); 1 Apr 2003 16:34:08 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 25033 invoked from network); 1 Apr 2003 16:34:07 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 1 Apr 2003 16:34:07 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 190Ohu-0006J6-00; Tue, 01 Apr 2003 10:33:54 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 190Ohq-0007mu-00; Tue, 01 Apr 2003 11:33:50 -0500 Date: Tue, 01 Apr 2003 16:34:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Nick Clifton , carlton@math.stanford.edu, gdb , binutils@sources.redhat.com Subject: Re: gdb.mi/mi-cli.exp failures Message-ID: <20030401163348.GA3830@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Nick Clifton , carlton@math.stanford.edu, gdb , binutils@sources.redhat.com References: <3E88A369.6090403@redhat.com> <3E88AE3F.4030005@redhat.com> <3E89AB79.1060700@redhat.com> <20030401151809.GA20117@nevyn.them.org> <3E89BCB1.3040900@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E89BCB1.3040900@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-04/txt/msg00006.txt.bz2 On Tue, Apr 01, 2003 at 11:22:09AM -0500, Andrew Cagney wrote: > > >On what target - I don't see these... > > RH 7.2 i386, PPC and d10v also show a jump in failures but I've not > checked that they are 100% identical. Bizarre, I can not reproduce this. > >This looks like a crash in the same function that changed interface... > >perhaps the memory leak fix for simple.c was wrong, although I can't > > Applying the simple.c change causes the problem. > > Index: simple.c > =================================================================== > RCS file: /cvs/src/src/bfd/simple.c,v > retrieving revision 1.5 > retrieving revision 1.6 > diff -u -r1.5 -r1.6 > --- simple.c 30 Nov 2002 08:39:40 -0000 1.5 > +++ simple.c 31 Mar 2003 18:13:25 -0000 1.6 > @@ -1,5 +1,5 @@ > /* simple.c -- BFD simple client routines > - Copyright 2002 > + Copyright 2002, 2003 > Free Software Foundation, Inc. > Contributed by MontaVista Software, Inc. > > @@ -135,7 +135,7 @@ > struct bfd_link_order link_order; > struct bfd_link_callbacks callbacks; > bfd_byte *contents, *data; > - int storage_needed, number_of_symbols; > + int storage_needed; > asymbol **symbol_table; > > if (! (sec->flags & SEC_RELOC)) > @@ -187,7 +187,7 @@ > > storage_needed = bfd_get_symtab_upper_bound (abfd); > symbol_table = (asymbol **) bfd_malloc (storage_needed); > - number_of_symbols = bfd_canonicalize_symtab (abfd, symbol_table); > + bfd_canonicalize_symtab (abfd, symbol_table); > > contents = bfd_get_relocated_section_contents (abfd, > &link_info, > @@ -208,5 +208,6 @@ > > bfd_link_hash_table_free (abfd, link_info.hash); > > + free (symbol_table); > return contents; > } > > A guess is that something still has a reference to the symbab. OK, that's pretty strange. It must be cached in the BFD somewhere. Do you have valgrind available? It will identify the access to a freed resource. I can't find the problem here, and reading the code I can not find the reference. > >quite see why. By the way, adding or removing the NULL at the end is > >all that GDB needs to do to work with both interfaces. > > Doesn't work. To test my patches, I've had to adjust upwards the > expected failure list. Don't follow... if you add/remove the NULL so that GDB compiles, it should work fine. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer