From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4125 invoked by alias); 2 Jun 2003 19:12:37 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 4097 invoked from network); 2 Jun 2003 19:12:36 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 2 Jun 2003 19:12:36 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19Muk2-0006nh-00; Mon, 02 Jun 2003 14:13:10 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19MujL-0002ru-00; Mon, 02 Jun 2003 15:12:27 -0400 Date: Mon, 02 Jun 2003 19:12:00 -0000 From: Daniel Jacobowitz To: Elena Zannoni Cc: David Carlton , gdb Subject: Re: [rfc] cp-symtab.c? Message-ID: <20030602191227.GA11011@nevyn.them.org> Mail-Followup-To: Elena Zannoni , David Carlton , gdb References: <16091.41599.3329.152064@localhost.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16091.41599.3329.152064@localhost.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00014.txt.bz2 On Mon, Jun 02, 2003 at 03:16:15PM -0400, Elena Zannoni wrote: > David Carlton writes: > > Elena and I were recently talking about moving > > make_symbol_overload_list and friends from symtab.c to some C++ file. > > It's not obvious to me where to put it, though; should I create a new > > file "cp-symtab.c" for that? If so, should I move the parts of > > cp-namespace.c that deal specifically with symbol lookup (all the > > functions in there with "lookup" in their name, I guess) to that file > > as well? My opinion is that the answer to both questions is "yes", > > but I wanted to check with other people first. > > > > David Carlton > > carlton@math.stanford.edu > > I would hold back on the new file, *for now*. I think cp-support.c > would work. Doing a grep for ^lookup_ in *.c throws up too many > things that are not clearly symbol table related, but for instance > gdbtypes and charset related. My guess is that the term 'lookup' has > been abused, and we should introduce something more qualifying in the > function names. I agree. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer