Re: deprecated_selected_frame

[Daniel Jacobowitz <drow@mvista.com>]

On Fri, Aug 01, 2003 at 03:21:34PM -0400, Andrew Cagney wrote:
> >Hi Andrew,
> >
> >Do you know of any places where converting to get_selected_frame () is
> >really wrong?
> 
> Most of the code should gain a frame parameter and receive the selected 
> frame that way.  Only the top level MI/CLI code, where the `selected 
> thread's selected frame' has meaning should get_selected_frame be used.
> 
> >A very few of the == NULL checks should probably stay for
> >now, but I bet that all of the uses shouldn't.
> 
> >I've got two independent bug reports caused by a NULL
> >deprecated_selected_frame on the 6.0 branch, and I fixed one last week.
> 
> The last one I saw was a top level MI routine so get_selected_frame 
> would make sense.

Oh, right - I remember your previous explanation of this now.

I don't have time to do that level of overhaul, but I do have a patch
which converts the 90% which are trivial to use get_selected_frame. 
Would you prefer that they be left and dealt with as encountered,
or updated with a FIXME at each?

They're all potential internal errors.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer