From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5673 invoked by alias); 1 Aug 2003 19:24:07 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 5666 invoked from network); 1 Aug 2003 19:24:07 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 1 Aug 2003 19:24:07 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19ifVW-0000XH-Ky; Fri, 01 Aug 2003 15:24:06 -0400 Date: Fri, 01 Aug 2003 19:24:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: gdb@sources.redhat.com Subject: Re: deprecated_selected_frame Message-ID: <20030801192406.GA2012@nevyn.them.org> Mail-Followup-To: Andrew Cagney , gdb@sources.redhat.com References: <20030801165826.GA26858@nevyn.them.org> <3F2ABDBE.9000904@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F2ABDBE.9000904@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00017.txt.bz2 On Fri, Aug 01, 2003 at 03:21:34PM -0400, Andrew Cagney wrote: > >Hi Andrew, > > > >Do you know of any places where converting to get_selected_frame () is > >really wrong? > > Most of the code should gain a frame parameter and receive the selected > frame that way. Only the top level MI/CLI code, where the `selected > thread's selected frame' has meaning should get_selected_frame be used. > > >A very few of the == NULL checks should probably stay for > >now, but I bet that all of the uses shouldn't. > > >I've got two independent bug reports caused by a NULL > >deprecated_selected_frame on the 6.0 branch, and I fixed one last week. > > The last one I saw was a top level MI routine so get_selected_frame > would make sense. Oh, right - I remember your previous explanation of this now. I don't have time to do that level of overhaul, but I do have a patch which converts the 90% which are trivial to use get_selected_frame. Would you prefer that they be left and dealt with as encountered, or updated with a FIXME at each? They're all potential internal errors. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer