From: Mark Kettenis <kettenis@chello.nl>
To: cagney@gnu.org
Cc: hunt@redhat.com, gdb@sources.redhat.com
Subject: Re: dwarf2-frame.c question for maintainers
Date: Thu, 15 Jul 2004 17:32:00 -0000 [thread overview]
Message-ID: <200407151601.i6FG1dcZ008932@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <40F58971.7000304@gnu.org> (message from Andrew Cagney on Wed, 14 Jul 2004 15:28:49 -0400)
Date: Wed, 14 Jul 2004 15:28:49 -0400
From: Andrew Cagney <cagney@gnu.org>
>>> How come extract_typed_address, in read_reg, doesn't sign extend?
>
>
> I should have explained that. It does. However extract_typed_address is
> incorrect because it makes the invalid assumption that sizeof(address)
> == sizeof(register). So that has to go and be replaced with something
> like
> extract_signed_integer (buf, register_size (current_gdbarch, regnum));
Martin, not all the world's a MIPS. Sign-extension is wrong here for
most targets.
You mean the builtin_type_void_data_ptr parameter to
extract_typed_address? Ah.
I see builtin_type_void_data_ptr dates back to 1.1 (Mark?). It could
instead use the register's type?
Nope. extract_typed_address only accepts a pointer type, and there's
no guarantee that the register's type is a pointer type.
Mark
next prev parent reply other threads:[~2004-07-15 16:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 22:01 Martin M. Hunt
2004-07-14 17:29 ` Andrew Cagney
2004-07-14 17:56 ` Martin M. Hunt
2004-07-14 19:38 ` Andrew Cagney
2004-07-15 17:32 ` Mark Kettenis [this message]
2004-07-15 17:40 ` Martin M. Hunt
2004-07-15 18:15 ` Andrew Cagney
2004-07-15 18:35 ` Martin M. Hunt
2004-07-15 18:45 ` Andrew Cagney
2004-07-15 18:54 ` Martin M. Hunt
2004-07-16 21:16 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200407151601.i6FG1dcZ008932@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=cagney@gnu.org \
--cc=gdb@sources.redhat.com \
--cc=hunt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).