From: Daniel Jacobowitz <drow@false.org>
To: Manoj Iyer <manjo@austin.ibm.com>
Cc: Michael Chastain <mec.gnu@mindspring.com>, gdb@sources.redhat.com
Subject: Re: [RFC] GDB testsuite patch.
Date: Wed, 25 Aug 2004 12:49:00 -0000 [thread overview]
Message-ID: <20040825124945.GA25217@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0408242319060.7065@lazy>
On Tue, Aug 24, 2004 at 11:29:12PM -0500, Manoj Iyer wrote:
>
> Hi all,
>
> Here is a patch to gdb/lib/gdb.exp, this patch handles the case when the
> GDB that is tested is stripped and has no debugging information.
>
> I have created this patch according to Michael's recomendations (see
> below).
Michael wrote:
> > Three of the four test scripts in gdb.gdb have their own 'setup_test',
> > and the fourth script has another copy of the same code. I would like
> > to see the common code factored into one place, lib/self-support.exp.
> >
> > Then setup_test calls gdb_load which calls gdb_file_cmd. You could get
> > into gdb_file_cmd and detect "(no debugging symbols found)" and add a
> > channel to return that information. Or, in setup_test, you could
> > do something right after the call to gdb_load to check for debugging
> > symbols.
> >
> > If there are no debugging symbols, then I think that the test script
> > should return one UNRESOLVED result and not continue testing.
> >
> > I'm not sure UNRESOLVED is the right result. Perhaps UNTESTED would
> > be better. But not UNSUPPORTED -- UNSUPPORTED means that a feature
> > is missing in the system under test.
That's not the same as what you've done. gdb_file_cmd should not
always fail for objects without debugging information, since there are
other tests that work OK without it. This only applies to the gdb.gdb/
tests.
--
Daniel Jacobowitz
next prev parent reply other threads:[~2004-08-25 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-19 18:10 gdb.gdb/ testcase issues Manoj Iyer
2004-08-19 21:23 ` Michael Chastain
2004-08-19 22:16 ` Manoj Iyer
2004-08-20 8:51 ` Michael Chastain
2004-08-25 5:03 ` [RFC] GDB testsuite patch Manoj Iyer
2004-08-25 12:49 ` Daniel Jacobowitz [this message]
2004-08-25 13:48 ` Michael Chastain
2004-08-25 13:44 ` Michael Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040825124945.GA25217@nevyn.them.org \
--to=drow@false.org \
--cc=gdb@sources.redhat.com \
--cc=manjo@austin.ibm.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).