* [PATCH] thread-db.c: Avoid segfault by making sure that ``reg'' is initialized
@ 2004-11-19 0:59 Kevin Buettner
2004-11-19 1:05 ` Kevin Buettner
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Buettner @ 2004-11-19 0:59 UTC (permalink / raw)
To: gdb
I've just committed the patch below. As indicated by the subject line, this
patch prevents a segfault when thread_db_set_thread_reg() returns an
uninitialized ``reg''. (This was happening on Fedora Core 2 due to lack of
xregset support.)
* thread-db.c (thread_db_set_thread_reg): Don't allow a successful
return without first initializing ``reg''.
Index: thread-db.c
===================================================================
RCS file: /cvs/src/src/rda/unix/thread-db.c,v
retrieving revision 1.9
diff -u -p -r1.9 thread-db.c
--- thread-db.c 20 Oct 2004 19:28:02 -0000 1.9
+++ thread-db.c 18 Nov 2004 21:39:21 -0000
@@ -2117,6 +2117,10 @@ thread_db_set_thread_reg (struct gdbserv
GREGSET_T gregset;
td_err_e ret;
+ /* Initialize reg to 0 in the event that we return early due to a
+ register being unsupported. */
+ gdbserv_ulonglong_to_reg (serv, 0LL, reg);
+
if (thread == NULL)
thread = process->event_thread; /* Default to the event thread. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] thread-db.c: Avoid segfault by making sure that ``reg'' is initialized
2004-11-19 0:59 [PATCH] thread-db.c: Avoid segfault by making sure that ``reg'' is initialized Kevin Buettner
@ 2004-11-19 1:05 ` Kevin Buettner
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Buettner @ 2004-11-19 1:05 UTC (permalink / raw)
To: gdb
On Thu, 18 Nov 2004 14:44:57 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> I've just committed the patch below. As indicated by the subject line, this
> patch prevents a segfault when thread_db_set_thread_reg() returns an
> uninitialized ``reg''. (This was happening on Fedora Core 2 due to lack of
> xregset support.)
>
> * thread-db.c (thread_db_set_thread_reg): Don't allow a successful
> return without first initializing ``reg''.
My apologies for sending this to the wrong list. This is an RDA patch, and
as such, I intended to send it to the RDA list.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-19 0:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-19 0:59 [PATCH] thread-db.c: Avoid segfault by making sure that ``reg'' is initialized Kevin Buettner
2004-11-19 1:05 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).