From: Bob Rossi <bob@brasko.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb@sources.redhat.com
Subject: Re: patch review time
Date: Fri, 04 Mar 2005 15:54:00 -0000 [thread overview]
Message-ID: <20050304155441.GC2419@white> (raw)
In-Reply-To: <01c520d0$Blat.v2.4$bbe28c40@zahav.net.il>
On Fri, Mar 04, 2005 at 05:41:10PM +0200, Eli Zaretskii wrote:
> > Date: Fri, 4 Mar 2005 09:26:00 -0500
> > From: Bob Rossi <bob@brasko.net>
> > Cc: gdb@sources.redhat.com
> >
> > On Fri, Mar 04, 2005 at 09:33:25AM +0200, Eli Zaretskii wrote:
> > > > Date: Thu, 3 Mar 2005 10:00:22 -0500
> > > > From: Bob Rossi <bob@brasko.net>
> > > >
> > > > I understand that people are busy, which is the very reason my patches
> > > > take so long to create. However, from my perspective it simply takes to long,
> > > > to get patch reviews done, except of course doco reviews from Eli :).
> > >
> > > I think I generally review all patches within my responsibility and/or
> > > area of expertise with the same speed, not only the doco ones.
> >
> > I think you are missing the point here Eli.
>
> No, I'm not: _you_ are.
>
> All I wanted to say that _my_ review time is short no matter if it's
> with documentation or code patches. In other words, I was protesting
> against your saying that just my _doco_ patches are fast enough.
Eli, what I'm trying to say is that the only thing *I* notice that get's
done fast is your doco patches for me. I was certainly not trying to say that
you don't do your other patch reviews fast. This complaint of mine is
specifically subjective, since I only know what's not being done fast
enough for me.
So when I say you are "missing the point", what I really mean to say is,
my above complaint wasn't about you doing your job well, it's about GDB
patch review time, for me, being to slow.
Sorry for the confusion.
> > Even in that respect, Andrew himself stated,
> >
> > It's taken us three months to get through files a-c, simple math tells
> > us that at that rate we'll finish sometime on '07. I don't think so.
>
> Please don't start that again. I told you right there and then that
> the i18n changes Andrew was referring to were going slow because of
> those who made changes, not because of the review process, since my
> comments on the i18n-related patches were posted at most a couple of
> days after the RFA, and normally just a few hours after the RFA.
Then let me ask you a qustion. Why did he not bother to get them
reviewed?
> > I'm calling for some type of action that will allow me to get some
> > real work done on GDB.
>
> Unfortunately, your changes are outside my authority and pretty much
> outside my expertise. Otherwise, they would have been reviewed eons
> ago.
Well what should I do? Honestly, waiting months for patch review time is
unacceptable. It would be helpful if the patches could be reviewed, on
average, in just a few days.
Thanks,
Bob Rossi
next prev parent reply other threads:[~2005-03-04 15:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 15:02 Bob Rossi
2005-03-04 7:35 ` Eli Zaretskii
2005-03-04 14:26 ` Bob Rossi
2005-03-04 14:59 ` Dave Korn
2005-03-04 15:36 ` 'Bob Rossi'
2005-03-04 15:43 ` Eli Zaretskii
2005-03-04 15:54 ` Bob Rossi [this message]
2005-03-04 17:39 ` Eli Zaretskii
2005-03-04 22:17 ` Bob Rossi
2005-03-05 11:28 ` Eli Zaretskii
2005-03-05 15:27 ` Bob Rossi
2005-03-05 17:13 ` Eli Zaretskii
2005-03-05 17:17 ` Kip Macy
2005-03-06 4:46 ` Eli Zaretskii
2005-03-06 6:24 ` Kip Macy
2005-03-06 18:54 ` Eli Zaretskii
2005-03-06 20:20 ` Bob Rossi
2005-03-05 20:34 Nick Roberts
2005-03-05 22:06 ` Bob Rossi
2005-03-05 22:15 ` Kip Macy
2005-03-06 13:45 ` Bob Rossi
2005-03-06 15:57 ` Daniel Jacobowitz
2005-03-06 18:06 ` Bob Rossi
2005-03-06 0:11 ` Russell Shaw
2005-03-06 13:48 ` Bob Rossi
2005-03-06 18:50 ` Eli Zaretskii
2005-03-06 20:17 ` Daniel Berlin
2005-03-06 20:29 ` Bob Rossi
2005-03-07 4:38 ` Eli Zaretskii
2005-03-07 23:49 ` Bob Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050304155441.GC2419@white \
--to=bob@brasko.net \
--cc=eliz@gnu.org \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).