From: Vladimir Prus <ghost@cs.msu.su>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb@sources.redhat.com
Subject: Re: problem debugging assembler functions
Date: Tue, 14 Jun 2005 14:54:00 -0000 [thread overview]
Message-ID: <200506141854.04712.ghost@cs.msu.su> (raw)
In-Reply-To: <20050614143654.GB3288@nevyn.them.org>
On Tuesday 14 June 2005 18:36, Daniel Jacobowitz wrote:
> On Tue, Jun 14, 2005 at 01:21:53PM +0400, Vladimir Prus wrote:
> > Line 2285:
> >
> > if (frame_id_eq (frame_unwind_id (get_current_frame ()), step_frame_id))
> > {
> > ......
> > }
>
> FYI, this bit...
>
> > Line 2428:
> >
> > if (step_over_calls == STEP_OVER_UNDEBUGGABLE
> > && ecs->stop_func_name == NULL)
> > {
> > /* The inferior just stepped into, or returned to, an
> > undebuggable function (where there is no symbol, not even a
> > minimal symbol, corresponding to the address where the
> > inferior stopped).
> > */
> >
> > ........
> >
> > insert_step_resume_breakpoint_at_frame (
> > get_prev_frame (get_current_frame ()));
> > }
>
> is somewhat newer than this bit.
>
> > The condition is the second code block is taken and breakpoint is indeed
> > set. I have two questions:
> >
> > 1. Is "just stepped into ... function" comment accurate? I think that all
> > cases of steppin into function are handled by the previous
> >
> > if (frame_id_eq (frame_unwind_id (get_current_frame ()), step_frame_id))
> > {}
> >
> > condition, and all code paths inside that condition end with return. So,
> > the second code block is not executed when we've just stepped into a
> > function. Is the code intended to handle only the case when we've
> > *returned* to undebuggable function?
>
> It was intended to handle both. Nowadays, there's a good chance it has
> handled only the latter.
Ok.
> > 2. In my case, no function names for assembler modules are present in
> > debug info, but line information is there, so the function is debuggable.
> > Is there a way to check of line info in condition, not for function name?
>
> You have line numbers, but not even minimal symbols? That is, ELF
> symbols, not DWARF2 symbols.
Exactly. ELF symbol table is absolutely empty.
> That's really bizarre.
Well, for a binary for embedded system with no dynamic linking this is not so
unreasonable. Anyway, that's not something I can easily change.
> We don't have a
> good interface for handling functions with line numbers but no sym or
> minsym, but perhaps we need one. I agree that the presence of line
> number information seems more relevant right here.
FWIW, I've just modified that code to be:
ecs->sal = find_pc_line (stop_pc, 0);
.......
if (step_over_calls == STEP_OVER_UNDEBUGGABLE
&& ecs->sal.line == 0)
and it works as expected. Does the change seem reasonable?
- Volodya
next prev parent reply other threads:[~2005-06-14 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 9:23 Vladimir Prus
2005-06-14 14:37 ` Daniel Jacobowitz
2005-06-14 14:54 ` Vladimir Prus [this message]
2005-06-14 14:58 ` Daniel Jacobowitz
2005-06-14 15:19 ` Vladimir Prus
2005-06-14 15:27 ` Daniel Jacobowitz
2005-07-14 8:54 ` Vladimir Prus
2005-07-14 14:11 ` Daniel Jacobowitz
2005-07-14 14:08 ` Vladimir Prus
2005-07-14 14:11 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506141854.04712.ghost@cs.msu.su \
--to=ghost@cs.msu.su \
--cc=drow@false.org \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).