From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7615 invoked by alias); 13 Jul 2005 03:59:06 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 7591 invoked by uid 22791); 13 Jul 2005 03:59:00 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 13 Jul 2005 03:59:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1DsYOf-0005mE-Vs; Tue, 12 Jul 2005 23:58:58 -0400 Date: Wed, 13 Jul 2005 03:59:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb@sources.redhat.com Subject: Re: -inferior-tty-show and -inferior-tty-set Message-ID: <20050713035857.GA22181@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb@sources.redhat.com References: <17108.33601.794016.525239@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17108.33601.794016.525239@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00143.txt.bz2 On Wed, Jul 13, 2005 at 02:58:09PM +1200, Nick Roberts wrote: > > -inferior-tty-show and -inferior-tty-set seem to accept any number of > arguments: > > (gdb) > -inferior-tty-show asdf > ^done > (gdb) > > (gdb) > -inferior-tty-set asdf qwert > ^done > (gdb) These we need to rediscuss whether to have at all - I'm still inclined to yes, you're still inclined to no, I haven't had time to sit down and write about it. > With mi_cmd_inferior_tty_set there is no test. mi_cmd_inferior_tty_show > uses mi_valid_noargs which returns 1 even with arguments (mi_getopt > only returns something other than -1 if it finds an option i.e an argument > starting with `-'). > > Since mi_cmd_file_list_exec_source_file and mi_cmd_file_list_exec_source_files > also use mi_valid_noargs, their associated MI commands also accept any number > of arguments. Ouch. That definitely ought to be fixed... -- Daniel Jacobowitz CodeSourcery, LLC