public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: kamaraju@gmail.com, fortran@gcc.gnu.org, gdb@sources.redhat.com
Subject: Re: gfortran - gdb problem
Date: Tue, 26 Jul 2005 03:19:00 -0000	[thread overview]
Message-ID: <20050726031703.GA25841@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0507230335130.11626@localhost.localdomain>

On Sat, Jul 23, 2005 at 03:43:58AM +0800, Wu Zhou wrote:
> My question here is: is it desirable to transfer the name to lower-case if 
> the language is case insensitive.  My point is that the compiler could handle 
> this and GDB needs only to handle what we get from the compiler.  

Generally it's the other way round: GDB must cope with whatever strange
things the compiler produces.

> As for this case, I don't know how other case-insensitive languages behave. 
> But it might helps to change the conditional expression to:
> 
>   case_sensitivity == case_sensitive_off && current_language->la_language != language_fortran
> 
> What do you think?  If there is any error, please correct me.  Thanks.

No; adding checks specific to the language is almost always wrong.  The
only case insensitive languages in the GDB source tree are Scheme (and
I don't think the Scheme support has worked in many years) and Fortran. 
So disabling it for Fortran is about the same as deleting the code
entirely.

Here's the original patch:
  http://sourceware.org/ml/gdb-patches/2000-08/msg00025.html

Presumably, whatever HP Fortran compiler Jimmy Guo was trying to add
support for always generated symbols in lowercase, so this was
sufficient.  gfortran doesn't.  It appears to use case somewhat
inconsistently.

The fact is, our symbol table does not support case insensitive lookup.
I suppose one cheap solution to this would be to lower case based on CU
language when reading in the symbol table, but that's not a very pretty
solution.  Perhaps Elena (the symbol table maintainer) has another idea.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

  reply	other threads:[~2005-07-26  3:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-25  7:31 Wu Zhou
2005-07-25 13:09 ` Daniel Jacobowitz
2005-07-26  3:05   ` Wu Zhou
2005-07-26  3:19     ` Daniel Jacobowitz [this message]
2005-07-26  6:57       ` David Lecomber
2005-07-26  9:01       ` Wu Zhou
2005-07-26 13:06         ` Daniel Jacobowitz
2005-07-28  3:43           ` Wu Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050726031703.GA25841@nevyn.them.org \
    --to=drow@false.org \
    --cc=fortran@gcc.gnu.org \
    --cc=gdb@sources.redhat.com \
    --cc=kamaraju@gmail.com \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).