From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4605 invoked by alias); 31 Aug 2005 19:33:15 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 4558 invoked by uid 22791); 31 Aug 2005 19:33:05 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 31 Aug 2005 19:33:05 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j7VJWGEp006368; Wed, 31 Aug 2005 21:32:16 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j7VJWFhV018527; Wed, 31 Aug 2005 21:32:15 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j7VJWBLL003494; Wed, 31 Aug 2005 21:32:11 +0200 (CEST) Date: Wed, 31 Aug 2005 19:33:00 -0000 Message-Id: <200508311932.j7VJWBLL003494@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pkoning@equallogic.com CC: gdb@sources.redhat.com In-reply-to: <17173.64766.911558.85264@gargle.gargle.HOWL> (message from Paul Koning on Wed, 31 Aug 2005 14:54:54 -0400) Subject: Re: -Wall References: <17173.64766.911558.85264@gargle.gargle.HOWL> X-SW-Source: 2005-08/txt/msg00126.txt.bz2 > Date: Wed, 31 Aug 2005 14:54:54 -0400 > From: Paul Koning > > Gdb (6.3 at least) generates a bunch of warnings when compiled with > -Wall (or a similar set of "warn for everything I can think of" > switches that are popular around here). > > Would patches to cure these be welcome? > configure.ac has this note: # NOTE: Don't add -Wall or -Wunused, they both include # -Wunused-parameter which reports bogus warnings. so currently GDB has its own set of warning flags, currently: build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \ -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \ -Wunused-label -Wunused-function" Further down there is: # Up for debate: -Wswitch -Wcomment -trigraphs -Wtrigraphs # -Wunused-function -Wunused-variable -Wunused-value # -Wchar-subscripts -Wtraditional -Wshadow -Wcast-qual # -Wcast-align -Wwrite-strings -Wconversion -Wstrict-prototypes # -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls # -Woverloaded-virtual -Winline -Werror" which probably qualifies as "warn for almost everything I can think of". The main reason for not enabling those is that there is still too much shoddy code in GDB that triggers these, making -Werror basically unusable. But I'd certainly welcome patches to remove warnings on that list. The best thing to do would probably be to target the options one at a time and then add the corresponding -W to the list used by GDB. Mark