From: Daniel Jacobowitz <drow@false.org>
To: Andrew STUBBS <andrew.stubbs@st.com>
Cc: GDB List <gdb@sources.redhat.com>
Subject: Re: $argc variable
Date: Mon, 07 Nov 2005 13:35:00 -0000 [thread overview]
Message-ID: <20051107133538.GA2331@nevyn.them.org> (raw)
In-Reply-To: <436F35E9.4070808@st.com>
On Mon, Nov 07, 2005 at 11:09:29AM +0000, Andrew STUBBS wrote:
> Daniel Jacobowitz wrote:
> >It's still in the review queue. I didn't like the implementation, but
> >I haven't had time to come up with a better one. If you feel like
> >helping... You'll notice no one else responded at the time when I
> >asked for comments.
>
> What, specifically, did you not like about the implementation?
>
> I'd be happy to have a bash at it, but it would be easier to avoid the
> same problems if I knew what they were.
Mostly, the coding style was very un-GNU. I also got the feeling that
there were better ways to do a lot of the string parsing, but I really
didn't spend much time looking at it (since I figured reimplementing
would be simpler in this case than FSF assignment).
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-11-07 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 13:11 Andrew STUBBS
2005-11-03 19:51 ` Dan Nicolaescu
2005-11-07 0:18 ` Daniel Jacobowitz
2005-11-07 11:12 ` Andrew STUBBS
2005-11-07 13:35 ` Daniel Jacobowitz [this message]
2005-11-08 13:05 ` Andrew STUBBS
2005-11-08 23:19 ` Eli Zaretskii
2005-11-09 11:15 ` Andrew STUBBS
2005-11-09 19:19 ` Eli Zaretskii
2005-11-10 10:11 ` Andrew STUBBS
2005-11-13 17:35 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107133538.GA2331@nevyn.them.org \
--to=drow@false.org \
--cc=andrew.stubbs@st.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).