From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28962 invoked by alias); 7 Nov 2005 13:35:49 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 28935 invoked by uid 22791); 7 Nov 2005 13:35:42 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 07 Nov 2005 13:35:42 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EZ79v-0000d1-6U; Mon, 07 Nov 2005 08:35:39 -0500 Date: Mon, 07 Nov 2005 13:35:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: GDB List Subject: Re: $argc variable Message-ID: <20051107133538.GA2331@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , GDB List References: <436A0BD2.5080505@st.com> <20051107001800.GF19200@nevyn.them.org> <436F35E9.4070808@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <436F35E9.4070808@st.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-11/txt/msg00144.txt.bz2 On Mon, Nov 07, 2005 at 11:09:29AM +0000, Andrew STUBBS wrote: > Daniel Jacobowitz wrote: > >It's still in the review queue. I didn't like the implementation, but > >I haven't had time to come up with a better one. If you feel like > >helping... You'll notice no one else responded at the time when I > >asked for comments. > > What, specifically, did you not like about the implementation? > > I'd be happy to have a bash at it, but it would be easier to avoid the > same problems if I knew what they were. Mostly, the coding style was very un-GNU. I also got the feeling that there were better ways to do a lot of the string parsing, but I really didn't spend much time looking at it (since I figured reimplementing would be simpler in this case than FSF assignment). -- Daniel Jacobowitz CodeSourcery, LLC