From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12648 invoked by alias); 7 Nov 2005 14:02:20 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 12633 invoked by uid 22791); 7 Nov 2005 14:02:16 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 07 Nov 2005 14:02:16 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EZ7Zd-0000p7-PL; Mon, 07 Nov 2005 09:02:13 -0500 Date: Mon, 07 Nov 2005 14:02:00 -0000 From: Daniel Jacobowitz To: Andrew STUBBS Cc: gdb@sources.redhat.com Subject: Re: RFC: GDB as a loader 2/3: return child result Message-ID: <20051107140213.GA3114@nevyn.them.org> Mail-Followup-To: Andrew STUBBS , gdb@sources.redhat.com References: <4354DC55.4090706@st.com> <20051105024606.GA20989@nevyn.them.org> <436F45D7.6010306@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <436F45D7.6010306@st.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-11/txt/msg00148.txt.bz2 On Mon, Nov 07, 2005 at 12:17:27PM +0000, Andrew STUBBS wrote: > Daniel Jacobowitz wrote: > >Sorry, I never got around to looking at the code portion of this. > >Would you mind making one cleanup for me? > > > >It doesn't really matter which header the externs go in. But they have > >to go in a header, visible at both the point of definition and the > >point of use. No externs in C files. top.h or main.h should be fine. > > Ok. How about the attached modification? Perfect with one addition: > * infrun.h: Include main.h. > * top.c; Include main.h. These mean you need to update Makefile.in, too. We use mostly manually computed dependencies. -- Daniel Jacobowitz CodeSourcery, LLC