* New Fortran test failures @ 2006-02-28 2:54 Daniel Jacobowitz 2006-02-28 14:04 ` Wu Zhou 0 siblings, 1 reply; 4+ messages in thread From: Daniel Jacobowitz @ 2006-02-28 2:54 UTC (permalink / raw) To: Wu Zhou; +Cc: gdb Hi Wu, Have you run the GDB testsuite lately? I don't have before-and-after results, but it looks like your recent Fortran patch caused extra whitespace after printing certain Fortran types, which shows up as failures in gdb.fortran/types.exp. I'm not sure why. -- Daniel Jacobowitz CodeSourcery ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New Fortran test failures 2006-02-28 2:54 New Fortran test failures Daniel Jacobowitz @ 2006-02-28 14:04 ` Wu Zhou 2006-02-28 15:46 ` Daniel Jacobowitz 0 siblings, 1 reply; 4+ messages in thread From: Wu Zhou @ 2006-02-28 14:04 UTC (permalink / raw) To: Daniel Jacobowitz; +Cc: gdb On Mon, 27 Feb 2006, Daniel Jacobowitz wrote: > Hi Wu, > > Have you run the GDB testsuite lately? I don't have before-and-after > results, but it looks like your recent Fortran patch caused extra > whitespace after printing certain Fortran types, which shows up as > failures in gdb.fortran/types.exp. I'm not sure why. Daniel, I had a look, it is the error of the following code: default_case: default: /* Handle types not explicitly handled by the other cases, such as fundamental types. For these, just print whatever the type name is, as recorded in the type itself. If there is no type name, then complain. */ if (TYPE_NAME (type) != NULL) fprintfi_filtered (level, stream, "%s ", TYPE_NAME (type)); The original code use "fputs_filtered (TYPE_NAME (type), stream);". When I replaced these un-idented functions with the indented oens, I incorrectly added a space after "%s". It seems that this stupid error escaped my test. Really sorry for that. Blush~~~~ Here is the fix. OK to install? 2006-02-28 Wu Zhou <woodzltc@cn.ibm.com> * f-typeprint.c (f_type_print_base): Delete the redundant space. Index: f-typeprint.c =================================================================== RCS file: /cvs/src/src/gdb/f-typeprint.c,v retrieving revision 1.15 diff -c -p -r1.15 f-typeprint.c *** f-typeprint.c 24 Feb 2006 07:26:10 -0000 1.15 --- f-typeprint.c 28 Feb 2006 02:01:13 -0000 *************** f_type_print_base (struct type *type, st *** 416,422 **** the type name is, as recorded in the type itself. If there is no type name, then complain. */ if (TYPE_NAME (type) != NULL) ! fprintfi_filtered (level, stream, "%s ", TYPE_NAME (type)); else error (_("Invalid type code (%d) in symbol table."), TYPE_CODE (type)); break; --- 416,422 ---- the type name is, as recorded in the type itself. If there is no type name, then complain. */ if (TYPE_NAME (type) != NULL) ! fprintfi_filtered (level, stream, "%s", TYPE_NAME (type)); else error (_("Invalid type code (%d) in symbol table."), TYPE_CODE (type)); break; After a little more thought, there is another potential problem in that testcase. It need the GNU fortran 95 compiler to run. This has to be specified on the command line explicitly (F77_FOR_TARGET=/usr/bin/gfortran). Otherwise it will reported "UNTESTED". Maybe we can let dejagnu automatically select gfortran as the compiler for ".f90" files. Ben, I know that you are the maintainer of dejagnu. Do you think that it is feasible to do that? OR there are any other methods? If you can point out a way for me, I am very happy to have a try. :-) Regards - Wu Zhou ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New Fortran test failures 2006-02-28 14:04 ` Wu Zhou @ 2006-02-28 15:46 ` Daniel Jacobowitz 2006-03-01 1:39 ` Wu Zhou 0 siblings, 1 reply; 4+ messages in thread From: Daniel Jacobowitz @ 2006-02-28 15:46 UTC (permalink / raw) To: Wu Zhou; +Cc: gdb On Mon, Feb 27, 2006 at 09:31:28PM -0500, Wu Zhou wrote: > Here is the fix. OK to install? > > 2006-02-28 Wu Zhou <woodzltc@cn.ibm.com> > > * f-typeprint.c (f_type_print_base): Delete the redundant space. Yeah, this is fine. Thank you. -- Daniel Jacobowitz CodeSourcery ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New Fortran test failures 2006-02-28 15:46 ` Daniel Jacobowitz @ 2006-03-01 1:39 ` Wu Zhou 0 siblings, 0 replies; 4+ messages in thread From: Wu Zhou @ 2006-03-01 1:39 UTC (permalink / raw) To: Daniel Jacobowitz; +Cc: gdb On Mon, 27 Feb 2006, Daniel Jacobowitz wrote: > On Mon, Feb 27, 2006 at 09:31:28PM -0500, Wu Zhou wrote: > > Here is the fix. OK to install? > > > > 2006-02-28 Wu Zhou <woodzltc@cn.ibm.com> > > > > * f-typeprint.c (f_type_print_base): Delete the redundant space. > > Yeah, this is fine. Thank you. Thanks. Committed. Here is what I just committed in. Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.7622 diff -c -p -r1.7622 ChangeLog *** ChangeLog 28 Feb 2006 22:38:03 -0000 1.7622 --- ChangeLog 1 Mar 2006 01:35:29 -0000 *************** *** 1,3 **** --- 1,7 ---- + 2006-03-01 Wu Zhou <woodzltc@cn.ibm.com> + + * f-typeprint.c (f_type_print_base): Delete the redundant space. + 2006-02-28 Kevin Buettner <kevinb@redhat.com> * Makefile.in (mn10300-linux-tdep.o): Update dependencies. Index: f-typeprint.c =================================================================== RCS file: /cvs/src/src/gdb/f-typeprint.c,v retrieving revision 1.15 diff -c -p -r1.15 f-typeprint.c *** f-typeprint.c 24 Feb 2006 07:26:10 -0000 1.15 --- f-typeprint.c 1 Mar 2006 01:35:29 -0000 *************** f_type_print_base (struct type *type, st *** 416,422 **** the type name is, as recorded in the type itself. If there is no type name, then complain. */ if (TYPE_NAME (type) != NULL) ! fprintfi_filtered (level, stream, "%s ", TYPE_NAME (type)); else error (_("Invalid type code (%d) in symbol table."), TYPE_CODE (type)); break; --- 416,422 ---- the type name is, as recorded in the type itself. If there is no type name, then complain. */ if (TYPE_NAME (type) != NULL) ! fprintfi_filtered (level, stream, "%s", TYPE_NAME (type)); else error (_("Invalid type code (%d) in symbol table."), TYPE_CODE (type)); break; Regards - Wu Zhou ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-03-01 1:39 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2006-02-28 2:54 New Fortran test failures Daniel Jacobowitz 2006-02-28 14:04 ` Wu Zhou 2006-02-28 15:46 ` Daniel Jacobowitz 2006-03-01 1:39 ` Wu Zhou
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).