From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: gdb@sourceware.org, personel personel <lepascal01@yahoo.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Debugging a Vlc dll with GDB.
Date: Fri, 07 Dec 2007 13:54:00 -0000 [thread overview]
Message-ID: <20071207135356.GA25201@caradoc.them.org> (raw)
In-Reply-To: <4758A871.9060508@portugalmail.pt>
On Fri, Dec 07, 2007 at 01:57:05AM +0000, Pedro Alves wrote:
> Humm, I found it useful, as in "ok, the breakpoint I set in a
> function that will only trigger after I do this, that, and that,
> is correctly set". Now, I have to interrupt the inferior and
> do an info breakpoints to see if it got in. If the breakpoint
> is in a plugin that gets loaded in reaction to some event, its
> even worse, as I'll have to poll...
Maybe there should be a single message when any number of pending
breakpoints are resolved? Anyway, one issue at a time.
> >> if (pending_break_support == AUTO_BOOLEAN_AUTO && - !nquery ("Make
> >> breakpoint pending on future shared library load? "))
> >> + !nquery (_("\
> >> +Make breakpoint pending on future symbol file addition? ")))
> > Accurate, but I don't like it much... sounds awkward.
> > For the rest, I don't really like the churn on messages; would it work
> > to just push the error down below *not_found_ptr = 1, and make it a
> > NOT_FOUND_ERROR?
>
> Yes it works, but do we want both the current error message,
> and NOT_FOUND_ERROR message that's already there, but not
> triggered currently, which is the message one usually sees?
> I guess you mean something like the attached?
No, I agree that looks silly. I meant:
> - if (!have_full_symbols () &&
> - !have_partial_symbols () && !have_minimal_symbols ())
> - error (_("No symbol table is loaded. Use the \"file\" command."));
> -
> if (not_found_ptr)
> *not_found_ptr = 1;
> + if (!have_full_symbols () &&
> + !have_partial_symbols () && !have_minimal_symbols ())
> + throw_error (NOT_FOUND_ERROR,
> + _("No symbol table is loaded. Use the \"file\" command."));
> throw_error (NOT_FOUND_ERROR, _("Function \"%s\" not defined."), copy);
That'll produce:
No symbol table is loaded. Use the "file" command.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (main) pending.
Of course that still looks wrong. It's not a shared library load that
we're waiting for.
Anyone else have concrete suggestions for these messages?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-07 13:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 17:38 personel personel
2007-12-06 17:53 ` Dave Korn
2007-12-06 18:23 ` Daniel Jacobowitz
2007-12-06 20:15 ` personel personel
2007-12-06 20:29 ` Daniel Jacobowitz
2007-12-06 20:57 ` Brian Dessent
2007-12-07 0:28 ` Pedro Alves
2007-12-07 0:42 ` Daniel Jacobowitz
2007-12-07 1:57 ` Pedro Alves
2007-12-07 13:54 ` Daniel Jacobowitz [this message]
2007-12-08 10:54 ` Eli Zaretskii
2007-12-07 16:21 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207135356.GA25201@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=lepascal01@yahoo.com \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).