From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17462 invoked by alias); 7 Dec 2007 13:54:07 -0000 Received: (qmail 17439 invoked by uid 22791); 7 Dec 2007 13:54:06 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Dec 2007 13:54:00 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 728A798349; Fri, 7 Dec 2007 13:53:58 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4AEE3982D9; Fri, 7 Dec 2007 13:53:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J0deO-0007iq-9O; Fri, 07 Dec 2007 08:53:56 -0500 Date: Fri, 07 Dec 2007 13:54:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb@sourceware.org, personel personel , gdb-patches Subject: Re: Debugging a Vlc dll with GDB. Message-ID: <20071207135356.GA25201@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb@sourceware.org, personel personel , gdb-patches References: <20071206182343.GA16137@caradoc.them.org> <433908.24398.qm@web57701.mail.re3.yahoo.com> <20071206202850.GA27429@caradoc.them.org> <47586224.CE80C330@dessent.net> <475893BA.8000700@portugalmail.pt> <20071207004226.GA30430@caradoc.them.org> <4758A871.9060508@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4758A871.9060508@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00059.txt.bz2 On Fri, Dec 07, 2007 at 01:57:05AM +0000, Pedro Alves wrote: > Humm, I found it useful, as in "ok, the breakpoint I set in a > function that will only trigger after I do this, that, and that, > is correctly set". Now, I have to interrupt the inferior and > do an info breakpoints to see if it got in. If the breakpoint > is in a plugin that gets loaded in reaction to some event, its > even worse, as I'll have to poll... Maybe there should be a single message when any number of pending breakpoints are resolved? Anyway, one issue at a time. > >> if (pending_break_support == AUTO_BOOLEAN_AUTO && - !nquery ("Make > >> breakpoint pending on future shared library load? ")) > >> + !nquery (_("\ > >> +Make breakpoint pending on future symbol file addition? "))) > > Accurate, but I don't like it much... sounds awkward. > > For the rest, I don't really like the churn on messages; would it work > > to just push the error down below *not_found_ptr = 1, and make it a > > NOT_FOUND_ERROR? > > Yes it works, but do we want both the current error message, > and NOT_FOUND_ERROR message that's already there, but not > triggered currently, which is the message one usually sees? > I guess you mean something like the attached? No, I agree that looks silly. I meant: > - if (!have_full_symbols () && > - !have_partial_symbols () && !have_minimal_symbols ()) > - error (_("No symbol table is loaded. Use the \"file\" command.")); > - > if (not_found_ptr) > *not_found_ptr = 1; > + if (!have_full_symbols () && > + !have_partial_symbols () && !have_minimal_symbols ()) > + throw_error (NOT_FOUND_ERROR, > + _("No symbol table is loaded. Use the \"file\" command.")); > throw_error (NOT_FOUND_ERROR, _("Function \"%s\" not defined."), copy); That'll produce: No symbol table is loaded. Use the "file" command. Make breakpoint pending on future shared library load? (y or [n]) y Breakpoint 1 (main) pending. Of course that still looks wrong. It's not a shared library load that we're waiting for. Anyone else have concrete suggestions for these messages? -- Daniel Jacobowitz CodeSourcery