From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb@sources.redhat.com
Subject: Re: -var-update using formatted value
Date: Sat, 19 Jan 2008 11:06:00 -0000 [thread overview]
Message-ID: <200801191405.20336.ghost@cs.msu.su> (raw)
In-Reply-To: <18319.57428.969644.640540@kahikatea.snap.net.nz>
On Friday 18 January 2008 02:10:12 Nick Roberts wrote:
> > Update stored value when format changes.
> >
> > * varobj.c (varobj_set_display_format): Recomputed
> > print_value.
> > (c_value_of_variable): Return print_value.
> >
> > diff --git a/gdb/varobj.c b/gdb/varobj.c
> > index d078bef..b0eb11a 100644
> > --- a/gdb/varobj.c
> > +++ b/gdb/varobj.c
> > @@ -677,6 +677,13 @@ varobj_set_display_format (struct varobj *var,
> > var->format = variable_default_display (var);
> > }
> >
> > + if (varobj_value_is_changeable_p (var)
> > + && var->value && !value_lazy (var->value))
> > + {
> > + free (var->print_value);
> > + var->print_value = value_get_print_value (var->value, var->format);
> > + }
> > +
> > return var->format;
> > }
> >
> > @@ -2260,7 +2267,7 @@ c_value_of_variable (struct varobj *var)
> >
> > gdb_assert (varobj_value_is_changeable_p (var));
> > gdb_assert (!value_lazy (var->value));
> > - return value_get_print_value (var->value, var->format);
> > + return strdup (var->print_value);
> > }
> > }
> > }
>
> I don't like this change. If I change the format to hexadecimal, 11 -> 0xb
> say, the display should change, so I would like GDB to report it through
> -var-update.
Why? It seems to me that if user does "change format" in UI, then UI should:
1. Change format
2. Display the value shown according to the new format
I cannot imagine any usecase where the frontend would:
1. Change format
2. Step program
3. Issue -var-update
- Volodya
>
next prev parent reply other threads:[~2008-01-19 11:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 15:13 Marc Khouzam
2008-01-11 17:40 ` Vladimir Prus
2008-01-11 18:31 ` Marc Khouzam
2008-01-11 19:40 ` Marc Khouzam
2008-01-11 22:26 ` Nick Roberts
2008-01-11 22:53 ` Andreas Schwab
2008-01-11 22:59 ` Daniel Jacobowitz
2008-01-11 23:40 ` Nick Roberts
2008-01-11 23:52 ` Daniel Jacobowitz
2008-01-12 3:41 ` Marc Khouzam
2008-01-12 3:49 ` Daniel Jacobowitz
2008-01-14 2:36 ` Marc Khouzam
2008-01-15 18:43 ` Vladimir Prus
2008-01-15 19:36 ` Marc Khouzam
2008-01-15 20:32 ` Vladimir Prus
2008-01-17 14:57 ` Marc Khouzam
2008-01-17 18:05 ` Vladimir Prus
2008-01-18 1:35 ` Nick Roberts
2008-01-18 15:31 ` Marc Khouzam
2008-01-18 15:41 ` Daniel Jacobowitz
2008-01-18 17:17 ` Marc Khouzam
2008-01-18 17:53 ` Daniel Jacobowitz
2008-01-18 19:26 ` Marc Khouzam
2008-01-18 21:10 ` Nick Roberts
2008-01-18 22:21 ` Marc Khouzam
2008-01-19 0:31 ` Nick Roberts
2008-01-19 1:46 ` Marc Khouzam
2008-01-19 8:27 ` Nick Roberts
2008-01-19 11:17 ` Vladimir Prus
2008-01-21 15:47 ` Marc Khouzam
2008-01-21 21:44 ` Nick Roberts
2008-01-17 23:10 ` Nick Roberts
2008-01-19 11:06 ` Vladimir Prus [this message]
2008-01-19 22:02 ` Nick Roberts
2008-01-20 10:04 ` Vladimir Prus
2008-01-20 20:16 ` Nick Roberts
2008-01-20 20:28 ` Vladimir Prus
2008-01-21 15:15 ` Marc Khouzam
2008-01-21 22:35 ` Nick Roberts
2008-01-29 21:20 ` Daniel Jacobowitz
2008-02-03 22:21 ` Nick Roberts
2008-02-04 6:15 ` Vladimir Prus
2008-01-18 0:53 ` Nick Roberts
2008-01-18 2:13 ` Marc Khouzam
2008-01-18 21:00 ` Nick Roberts
2008-01-18 22:04 ` Marc Khouzam
2008-01-14 6:34 ` Nick Roberts
2008-01-29 21:26 ` Daniel Jacobowitz
2008-01-29 23:49 ` Nick Roberts
2008-01-30 0:04 ` Daniel Jacobowitz
2008-01-30 4:25 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801191405.20336.ghost@cs.msu.su \
--to=ghost@cs.msu.su \
--cc=gdb@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).