From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>, Joel Brobecker <brobecker@adacore.com>
Cc: gdb@sourceware.org
Subject: Re: gdbtypes.h #defined field accessors
Date: Tue, 29 Jun 2010 23:15:00 -0000 [thread overview]
Message-ID: <20100629231536.GA14920@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100628205701.GC2700@adacore.com> <m3oceux59g.fsf@fleche.redhat.com>
On Mon, 28 Jun 2010 22:37:47 +0200, Tom Tromey wrote:
> Though FWIW, little of the GDB work I've done seems amenable to automation,
> even the grungy add-an-argument-to-val_print stuff :-(
I have to agree...
> I tend to stick with the style of a given module.
>
> In new code I don't generally write accessors.
OK.
On Mon, 28 Jun 2010 22:57:01 +0200, Joel Brobecker wrote:
> > In new code I don't generally write accessors.
>
> I don't know if this is relevant to this particular discussion, but
> I tend to like opaque structures and accessors (setter/getter) functions,
> and I try to use that when writing new code.
While it is not relevant to your "new code" note this is what I miss on the
GDB accessors - they would be (more) useful separated into getters/setters.
It would easily enable providing various currently constant fields as dynamic
DWARF blocks.
Thanks,
Jan
prev parent reply other threads:[~2010-06-29 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 19:57 Jan Kratochvil
2010-06-28 20:37 ` Tom Tromey
2010-06-28 20:57 ` Joel Brobecker
2010-06-30 21:51 ` Tom Tromey
2010-06-29 23:15 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629231536.GA14920@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).