From: Daniel Jacobowitz <dan@codesourcery.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>,
gdb@sourceware.org, Richard Earnshaw <rearnsha@arm.com>
Subject: Re: ARM prologue parsing support for Thumb-2 instructions?
Date: Mon, 19 Jul 2010 14:10:00 -0000 [thread overview]
Message-ID: <20100719141029.GI6088@caradoc.them.org> (raw)
In-Reply-To: <201007191059.o6JAx5r0026004@d12av02.megacenter.de.ibm.com>
On Mon, Jul 19, 2010 at 12:59:05PM +0200, Ulrich Weigand wrote:
> > Trunk thumb_analyze_prologue does have support for Thumb-2.
>
> Well, all the support for Thumb-2 I can see is in this block:
>
> else if ((insn & 0xe000) == 0xe000 && cache == NULL)
> {
> /* Only recognize 32-bit instructions for prologue skipping. */
>
> which, as the comment says, is active *only* if this routine is
> called from arm_skip_prologue (with cache == NULL), but not if the
> routine is called from arm_scan_prologue (with cache != NULL),
> which is what is used during unwinding.
IIRC, it would not be hard to fill in the missing pieces; I just
didn't need them at the time, and could not easily test them. So
rather than risk them being wrong, I left them for later.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2010-07-19 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 17:03 Ulrich Weigand
2010-07-16 19:37 ` Daniel Jacobowitz
2010-07-19 8:51 ` Matthew Gretton-Dann
2010-07-19 10:59 ` Ulrich Weigand
2010-07-19 14:10 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719141029.GI6088@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb@sourceware.org \
--cc=matthew.gretton-dann@arm.com \
--cc=rearnsha@arm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).