From: Pedro Alves <pedro@codesourcery.com>
To: gdb@sourceware.org
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: Re: output-radix breaks char output
Date: Tue, 08 Nov 2011 15:13:00 -0000 [thread overview]
Message-ID: <201111081512.43822.pedro@codesourcery.com> (raw)
In-Reply-To: <201111072339.09196.vapier@gentoo.org>
On Tuesday 08 November 2011 04:39:08, Mike Frysinger wrote:
> am i doing something wrong here ? seems like setting output-radix to 16
> breaks x/c output.
>
> $ echo 'char f[]="abc";main(){}' | gcc -x c -g - -o a.out
> $ gdb ./a.out
> (gdb) b main
> (gdb) r
> (gdb) set output-radix 10
> Output radix now set to decimal 10, hex a, octal 12.
> (gdb) x/4c f
> 0x601018 <f>: 97 'a' 98 'b' 99 'c' 0 '\000'
> (gdb) set output-radix 16
> Output radix now set to decimal 16, hex 10, octal 20.
> (gdb) x/4c f
> 0x601018 <f>: 0x61 0x62 0x63 0x0
>
> i can understand the 0x61/97 change, but imo, the latter output shouldn't be
> missing the 'a' bits.
I agree.
static void
set_output_radix_1 (int from_tty, unsigned radix)
{
/* Validate the radix and disallow ones that we aren't prepared to
handle correctly, leaving the radix unchanged. */
switch (radix)
{
case 16:
user_print_options.output_format = 'x'; /* hex */
break;
case 10:
user_print_options.output_format = 0; /* decimal */
break;
case 8:
user_print_options.output_format = 'o'; /* octal */
break;
default:
So radix==10 means "no format", and other radices work as if
the user overrode the format whenever printing, basically
the same as:
(top-gdb) p **argv
$3 = 47 '/'
GDB knew that was a char from the type.
(top-gdb) p /d **argv
$4 = 47
... when overridden as decimal number, the '/' is gone.
(top-gdb) x /d *argv
0x7fffffffe30a: 47
... same with `x' (the machinery that decides this is basically the same).
(top-gdb) p /x **argv
$5 = 0x2f
(top-gdb) p /o **argv
$6 = 057
(top-gdb) p /c **argv
$7 = 47 '/'
... and other formats too.
--
Pedro Alves
next prev parent reply other threads:[~2011-11-08 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 4:39 Mike Frysinger
2011-11-08 15:13 ` Pedro Alves [this message]
2011-11-08 17:04 ` Tom Tromey
2011-11-08 18:11 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111081512.43822.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).