From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31743 invoked by alias); 28 Nov 2011 22:09:34 -0000 Received: (qmail 31728 invoked by uid 22791); 28 Nov 2011 22:09:32 -0000 X-SWARE-Spam-Status: No, hits=-50.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mho-03-ewr.mailhop.org (HELO mho-01-ewr.mailhop.org) (204.13.248.66) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Nov 2011 22:09:19 +0000 Received: from pool-173-76-42-41.bstnma.fios.verizon.net ([173.76.42.41] helo=cgf.cx) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1RV9O2-000Hnk-Aq; Mon, 28 Nov 2011 22:09:18 +0000 Received: from localhost (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 5DB3F13C0D3; Mon, 28 Nov 2011 17:09:17 -0500 (EST) X-Mail-Handler: MailHop Outbound by DynDNS X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+aMerBE0M/ipk3zl62TO7h Date: Mon, 28 Nov 2011 22:09:00 -0000 From: Christopher Faylor To: gdb@sourceware.org, Andrey Smirnov , Joel Brobecker Subject: Re: Two quick questions Message-ID: <20111128220917.GA10254@ednor.casa.cgf.cx> Mail-Followup-To: gdb@sourceware.org, Andrey Smirnov , Joel Brobecker References: <87wrak63cd.fsf@gmail.com> <20111128153809.GB17887@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111128153809.GB17887@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00122.txt.bz2 On Mon, Nov 28, 2011 at 07:38:09AM -0800, Joel Brobecker wrote: >> 1. Since neither >> http://www.sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html >> nor http://sourceware.org/gdb/wiki/JoelsCodingStyleCheatSheet >> mentions this, or at least yours myopic truly haven't noticed it, >> I wonder what is the GDB's allegiance in the Tabs, Spaces, Tabs + >> Spaces holy war? Who are the infidels we must crush? :) The >> reason I'm asking is that I don't want to generate false diffs >> just because I re-indented the line in different style. > >We use tabs mostly, optionally followed by spaces if a line of code >doesn't exactly start at a tabulation. Although it's perfectly fine >to tabify a line of code that you're modifying, I would personally >prefer that you don't touch lines just for the sake of tabifying. >Others might disagree (hence the "personally"), but these little >changes don't bring anything in terms of readability, mess up the >indentation when reading diffs, and also potentially create merge >conflicts for changes that are essentially no-ops. I think most people would agree that gratuitously reindenting lines that haven't been touched is really a bad idea. >> Where is that "gdb GNATS bug reporting database"? I can't help but >> feel guilty for being a security threat, but I just can't find it. >> There is a Bugzilla, I've seen it, but those two don't seem to be >> related. > >I don't know much about that one, and who might have created an >account for you. For GDB, we've transitioned to buzilla, as you >have found. We used to use gnats, but no more. Wow, that's ancient. I need to move that message into the 21st century. Also, I suspect that the script shouldn't be creating bugzilla accounts at all. cgf