public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Jeffrey Walton <noloader@gmail.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>, gdb@sourceware.org
Subject: Re: Switch -Wunused-variable on?
Date: Mon, 23 Apr 2012 08:55:00 -0000	[thread overview]
Message-ID: <20120423085504.GA562@host2.jankratochvil.net> (raw)
In-Reply-To: <CAH8yC8komGQs-Cm7OUPGuz5YOe7ze97xk2NKYnWnjsxDJWzsSA@mail.gmail.com>

On Mon, 23 Apr 2012 00:25:36 +0200, Jeffrey Walton wrote:
> On Sun, Apr 22, 2012 at 4:24 PM, Sergio Durigan Junior <sergiodj@redhat.com> wrote:
> > Yes, this is a counter-argument, and I was also thinking about it.  I
> > don't know how people prefer to deal with this issue,

I would find right to properly #if-compile even the variable declaration but
I do not have real experience how complicated it may be.


> >    #define USED_VAR(var) ((void) var)
> 
> I use this technique when using -Wall. It even works on Visual Studio,
> so the technique is portable.

Sourceware is using ATTRIBUTE_UNUSED.


Thanks,
Jan

  reply	other threads:[~2012-04-23  8:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-22  8:06 Sergio Durigan Junior
2012-04-22  8:23 ` Jan Kratochvil
2012-04-22 20:25   ` Sergio Durigan Junior
2012-04-22 22:25     ` Jeffrey Walton
2012-04-23  8:55       ` Jan Kratochvil [this message]
2012-04-23 14:30     ` Tom Tromey
2012-04-23 15:49       ` Sergio Durigan Junior
2012-04-23 18:02         ` Pedro Alves
2012-04-23 18:39           ` Michael Eager
2012-04-24 22:11       ` Maciej W. Rozycki
2012-04-25  7:51         ` Andreas Schwab
2012-04-25 15:57           ` Maciej W. Rozycki
2012-04-25 16:50             ` Andreas Schwab
2012-04-25 17:22               ` Maciej W. Rozycki
2012-04-25 18:13                 ` Andreas Schwab
2012-04-25 18:20                   ` Sterling Augustine
2012-04-25 18:52                     ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423085504.GA562@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb@sourceware.org \
    --cc=noloader@gmail.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).