From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-40898-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 10821 invoked by alias); 14 May 2012 14:57:14 -0000
Received: (qmail 10802 invoked by uid 22791); 14 May 2012 14:57:13 -0000
X-SWARE-Spam-Status: No, hits=-3.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 May 2012 14:56:58 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 12F451C6EE9;	Mon, 14 May 2012 10:56:58 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id jBrA5d5xJykS; Mon, 14 May 2012 10:56:58 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id CAADD1C6ED5;	Mon, 14 May 2012 10:56:57 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 1CCC1145616; Mon, 14 May 2012 07:56:50 -0700 (PDT)
Date: Mon, 14 May 2012 14:57:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: oza Pawandeep <oza.pawandeep@gmail.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb@sourceware.org,	gdb-patches@sourceware.org
Subject: Re: [design change] record-replay linux ABI level
Message-ID: <20120514145650.GF10253@adacore.com>
References: <CAK1A=4xtgYd8hQEwHxjLQiv4eqhCu0cSRDmmbFJvBDJwDxUM+Q__46748.0269181125$1336555010$gmane$org@mail.gmail.com> <87sjf9qecr.fsf@fleche.redhat.com> <CAK1A=4xbh0M=yfc2MQpZdDCJEPnL3_z8=TA0VSE7qVCoO0Dn-Q__42617.423789534$1336639800$gmane$org@mail.gmail.com> <87aa1gqhnq.fsf@fleche.redhat.com> <CAK1A=4wzBfbc1OpbP2BNMGVw0iiWMG81fy1+peq_r5rFkenyhA@mail.gmail.com> <CAK1A=4zRULTC9Tue8Wu7vYpCiHE-sWBLHU7P9uw0d8MO0YRUpA@mail.gmail.com> <CAK1A=4y7d8ot_G+O8oFm_ZVDT9q7QdFu87hMXT=+mHfVuJPnTw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK1A=4y7d8ot_G+O8oFm_ZVDT9q7QdFu87hMXT=+mHfVuJPnTw@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00054.txt.bz2

> static enum gdb_syscall
> arm_canonicalize_syscall (int syscall)
> {
>   enum { arm_sys_prlimit64 = 369 };
> 
>   if (syscall <= arm_sys_prlimit64)
>     {
>       if (syscall <= gdb_sys_sched_getaffinity)
>         return syscall;
>       else if (syscall <= gdb_sys_fadvise64_64)
>         {
>           return (syscall + (unsigned int)2);
>         }
>       else
>         {
>           switch (syscall)

Why not define a table that defines the mapping for every syscall?
We do that for registers -vs- register names, for instance, and that
works very well.

    static enum gdb_syscall arm_syscal_map[] =
    {
      gdb_sys_restart_syscall, gdb_sys_exit, gdb_sys_fork,
      [...]
      gdb_sys_sched_getaffinity, gdb_sys_arm_trap16,
      [...]
    };

-- 
Joel