From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22558 invoked by alias); 19 May 2012 03:49:22 -0000 Received: (qmail 22534 invoked by uid 22791); 19 May 2012 03:49:20 -0000 X-SWARE-Spam-Status: No, hits=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 May 2012 03:49:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 7B0091B4016; Sat, 19 May 2012 03:49:06 +0000 (UTC) From: Mike Frysinger To: binutils@sourceware.org Subject: Re: [PATCH] MIPS/sim: Fix build breakage Date: Sat, 19 May 2012 03:49:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.4.0-rc6; KDE/4.6.5; x86_64; ; ) Cc: "Maciej W. Rozycki" , Alan Modra , Cary Coutant , Tom Tromey , Nick Clifton , gdb@sourceware.org, gdb-patches@sourceware.org References: <87k40alojr.fsf@fleche.redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3884100.QqRzi1UiZD"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201205182349.45580.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00097.txt.bz2 --nextPart3884100.QqRzi1UiZD Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 2174 On Friday 18 May 2012 10:26:35 Maciej W. Rozycki wrote: > This fixes the build for me, I can connect to the MIPS simulator and > single-step, examine registers, etc., so it seems to work, but I haven't > verified it further, I am not fully set up to run GNU sim testing right > now. Obviously other targets may require further tweaks. Nick posted a patch to fix things. are you guys fighting over who gets the= re=20 first ? :) > It looks like some generated files (i.e. ppc and the top-level) were not > rebuilt at the last check-in time too, hence differences beyond those > one'd expect from this change alone. the ppc/ subdir doesn't use common/, so there's no need to regen when it=20 changes. the changes you show here are just updated autotools, and ones i= =20 haven't bothered committing. you may if you like, just providing info. maybe it's me, but i also don't typically include the regenerated output in= =20 the diffs posted to the list since they're generally noise. would rather f= ocus=20 on the things that the dev is changing. > * gentmap.c (gen_targ_map_c): Produce "sim-main.h" inclusion. how come ? > --- gdb-fsf-trunk-quilt.orig/sim/common/acinclude.m4 > +++ gdb-fsf-trunk-quilt/sim/common/acinclude.m4 > @@ -28,6 +28,9 @@ AC_DEFUN([SIM_AC_COMMON], > AC_REQUIRE([AC_PROG_CC]) > # autoconf.info says this should be called right after AC_INIT. > AC_CONFIG_HEADER(ifelse([$1],,config.h,[$1]):config.in) > +PACKAGE=3Dsim > +AC_DEFINE_UNQUOTED(PACKAGE, "$PACKAGE", [Name of this package.]) > +AC_SUBST(PACKAGE) > AC_CANONICAL_SYSTEM > AC_USE_SYSTEM_EXTENSIONS > AC_ARG_PROGRAM i'd relocate this new code further down in the SIM_AC_COMMON definition. m= aybe=20 above the "# Dependency checking." line. > --- gdb-fsf-trunk-quilt.orig/sim/igen/configure.ac > +++ gdb-fsf-trunk-quilt/sim/igen/configure.ac > @@ -3,6 +3,10 @@ AC_PREREQ(2.59)dnl > AC_INIT(table.h) > sinclude(../common/acinclude.m4) >=20 > +PACKAGE=3Dsim > +AC_DEFINE_UNQUOTED(PACKAGE, "$PACKAGE", [Name of this package.]) > +AC_SUBST(PACKAGE) > + > AC_PROG_INSTALL > AC_PROG_CC hrm, we should prob look at migrating igen more over to the common m4 code -mike --nextPart3884100.QqRzi1UiZD Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPtxhWAAoJEEFjO5/oN/WB0q0P/jZPfjOUViH6Ahq1Fy2A8iPX Qi+WDFHTqpOiT3ss0x1kcG1kiV8zvMIEP9apXUJ+P3KwLYlwXw/luOAL7O9B/t4g Ed9zZBDyW1nWtvBSXOWe++8/oSI88PZpKMDON/q09MyxSKvMi8+Vh0l/MmWbJ/bp wJZkoLD6EVcTXT8k8puMuKU/pH1ziPRc/8EhBAOjSNupU3rIZ2d+mRXGniANN55f yE+ahONDKPJuOCwg9+Xw4u8d179tr7vef8xCFJu4T9WPY6yWcZy2fycgp3y9qKbf efC86/5IXr2u6BgcmH4yPBp1BXg8T4uwElpi1oW90nKJRt5KDLYn3hHAVoxqX2Mh VkzQT6ZJjzQSdMdifvL8CQAC2iRLVGynRaLyH/e6Gjrpl6lvpskUxbW7dXG6Gk5x zizKRlgQ8QIzOOm3YmMRizYe8jgF4qToSIf2yOcqYtb/e5v2Pj0tEfW1i9iDvoQs gYOOpfJCI62yaUTGJd0C6L5CCVJI7ivuLvvKuSLbTp1W3KAdMOqeHWzwoUOM/2Dc 6qYiX4NvQavp5Qki8/HiVSN30HWW8KU8OoCD4z7VQjjW2sUtn880C4D+lUfJk4CO aN+Vw+EdZIu1YAsWYMJ+ZwJBVKgbkPUApDAKQlgT9g2wmAaRLnFcldAKO8lh1Dsn yilJ+gu47BjkipRsMnvT =hfUg -----END PGP SIGNATURE----- --nextPart3884100.QqRzi1UiZD--