From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23364 invoked by alias); 6 Dec 2012 16:25:10 -0000 Received: (qmail 23318 invoked by uid 22791); 6 Dec 2012 16:25:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.openrapids.net (HELO blackscsi.openrapids.net) (64.15.138.104) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 16:25:01 +0000 Received: from localhost (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id ADCEC14026E; Thu, 6 Dec 2012 11:25:00 -0500 (EST) Received: from blackscsi.openrapids.net ([127.0.0.1]) by localhost (blackscsi.openrapids.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EF4DeOfqn5Ur; Thu, 6 Dec 2012 11:24:59 -0500 (EST) Received: by blackscsi.openrapids.net (Postfix, from userid 1003) id 7732B14032C; Thu, 6 Dec 2012 11:24:59 -0500 (EST) Date: Thu, 06 Dec 2012 16:25:00 -0000 From: Mathieu Desnoyers To: Pedro Alves , Julien Desfossez Cc: Hui Zhu , lttng-dev , Tom Tromey , gdb@sourceware.org Subject: Re: [lttng-dev] Request change name of function lookup_enum in libbabeltrace to make GDB use this lib Message-ID: <20121206162459.GB17469@Krystal> References: <20121205120845.GA31696@Krystal> <50C0C06A.40207@redhat.com> <50C0C5C1.4070101@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C0C5C1.4070101@redhat.com> X-Editor: vi User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00029.txt.bz2 * Pedro Alves (palves@redhat.com) wrote: > On 12/06/2012 03:57 PM, Pedro Alves wrote: > > On 12/05/2012 12:08 PM, Mathieu Desnoyers wrote: > >> * Hui Zhu (teawater@gmail.com) wrote: > >>> Hi, > >>> > >>> I am working on add CTF support to GDB. You can see my patch review threads in: > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00552.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00554.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00553.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00556.html > >>> > >>> To make GDB support CTF read, I use libbabeltrace with GDB. You can > >>> see the patch in > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html. > >>> I have a issue is libbabeltrace have a function called lookup_enum > >>> that is same with a GDB function. > >>> I change the function name of GDB to handle this issue in my patch. > >>> > >>> But Tom said let libbabeltrace to change function name is better. > >>> So I send this mail to ask do you mind change the function name of > >>> lookup_enum? If you can change the function name that will be really > >>> helpful for us. Thanks a lot. > >>> And I post a patch about change the function name in libbabeltrace. > >> > >> I'm CCing Julien Desfossez on this one. From what I see, > >> include/babeltrace/types.h is not included into the system, so it should > >> not be considered to be a public header of libbabeltrace. > > > > I've just built and installed babeltrace 1.0.0 (where's the mainline repository, > > BTW?), and indeed, I'm not seeing the types.h file anywhere in the > > installed tree: > > (found mainline at http://www.efficios.com/babeltrace) > > I installed mainline, and quickly skimmed the headers. It seems most of the > symbols are already namespace clean, using bt_ or babeltrace_ as prefix, > but I did spot some problems: > > context.h: > > struct bt_context; > struct stream_pos; > ^^^^^^^^^^^^^^^^^ > struct bt_ctf_event; Good catch. Yes this one is installed. > > > ctf/events.h: > > struct definition; > ^^^^^^^^^^^^^^^^^ > struct declaration; > ^^^^^^^^^^^^^^^^^^ > struct bt_ctf_event; > struct bt_ctf_event_decl; > struct bt_ctf_field_decl; Yes. > It'd be very good if those (and any others I might have missed) were bt_ prefixed too. Indeed. Julien, can you review all those public headers and ensure they are correctly namespaced ? Thanks, Mathieu > > Thanks, > -- > Pedro Alves > -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com