From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32356 invoked by alias); 10 Dec 2012 14:05:38 -0000 Received: (qmail 32339 invoked by uid 22791); 10 Dec 2012 14:05:36 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.openrapids.net (HELO blackscsi.openrapids.net) (64.15.138.104) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Dec 2012 14:05:26 +0000 Received: from localhost (localhost [127.0.0.1]) by blackscsi.openrapids.net (Postfix) with ESMTP id C8122140518; Mon, 10 Dec 2012 09:05:25 -0500 (EST) Received: from blackscsi.openrapids.net ([127.0.0.1]) by localhost (blackscsi.openrapids.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K9OOfEL0rVp1; Mon, 10 Dec 2012 09:05:24 -0500 (EST) Received: by blackscsi.openrapids.net (Postfix, from userid 1003) id 8198A140525; Mon, 10 Dec 2012 09:05:24 -0500 (EST) Date: Mon, 10 Dec 2012 14:05:00 -0000 From: Mathieu Desnoyers To: Hui Zhu Cc: Pedro Alves , Julien Desfossez , lttng-dev , Tom Tromey , gdb@sourceware.org Subject: Re: [lttng-dev] Request change name of function lookup_enum in libbabeltrace to make GDB use this lib Message-ID: <20121210140524.GA31945@Krystal> References: <20121205120845.GA31696@Krystal> <50C0C06A.40207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Editor: vi User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00042.txt.bz2 * Hui Zhu (teawater@gmail.com) wrote: > On Thu, Dec 6, 2012 at 11:57 PM, Pedro Alves wrote: > > On 12/05/2012 12:08 PM, Mathieu Desnoyers wrote: > >> * Hui Zhu (teawater@gmail.com) wrote: > >>> Hi, > >>> > >>> I am working on add CTF support to GDB. You can see my patch review threads in: > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00552.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00554.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00553.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00556.html > >>> > >>> To make GDB support CTF read, I use libbabeltrace with GDB. You can > >>> see the patch in > >>> http://sourceware.org/ml/gdb-patches/2012-11/msg00555.html. > >>> I have a issue is libbabeltrace have a function called lookup_enum > >>> that is same with a GDB function. > >>> I change the function name of GDB to handle this issue in my patch. > >>> > >>> But Tom said let libbabeltrace to change function name is better. > >>> So I send this mail to ask do you mind change the function name of > >>> lookup_enum? If you can change the function name that will be really > >>> helpful for us. Thanks a lot. > >>> And I post a patch about change the function name in libbabeltrace. > >> > >> I'm CCing Julien Desfossez on this one. From what I see, > >> include/babeltrace/types.h is not included into the system, so it should > >> not be considered to be a public header of libbabeltrace. > > > > I've just built and installed babeltrace 1.0.0 (where's the mainline repository, > > BTW?), and indeed, I'm not seeing the types.h file anywhere in the > > installed tree: > > > > $ ~/src/babeltrace/install/include> find > > . > > ./babeltrace > > ./babeltrace/trace-handle.h > > ./babeltrace/list.h > > ./babeltrace/babeltrace.h > > ./babeltrace/context.h > > ./babeltrace/iterator.h > > ./babeltrace/ctf > > ./babeltrace/ctf/callbacks.h > > ./babeltrace/ctf/events.h > > ./babeltrace/ctf/iterator.h > > ./babeltrace/format.h > > ./babeltrace/clock-types.h > > > > The GDB patch is including types.h explicitly: > > > > +#ifdef HAVE_LIBBABELTRACE > > +#include > > +#include > > +#include > > +#include > > > > So indeed, Hui, you'll need to make sure your patch works against an > > installed babeltrace, making sure it does not pick up headers > > from babeltrace's source directory. If there's really no reason to > > include that types.h header (since it seems you don't really need any > > function declared in that file), maybe there's actually nothing for > > babeltrace to do. > > Oops, sorry for I miss something. > I use include babeltrace/types.h because I use function > get_int_signedness that defined inside it. Can you use: include/babeltrace/ctf/events.h: bt_ctf_get_int_signedness() instead ? This one is within an exported header, Thanks, Mathieu > > Thanks, > Hui > > > > > >> Julien, is there an publically exposed babeltrace API that performs > >> something similar to the internal lookup_enum() ? > >> > >> Hui, are you using other functions from include/babeltrace/types.h ? > > > > -- > > Pedro Alves > > -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com