From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9520 invoked by alias); 13 Dec 2012 15:12:47 -0000 Received: (qmail 9382 invoked by uid 22791); 13 Dec 2012 15:12:43 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 15:12:36 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBDFCYuA018431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Dec 2012 10:12:34 -0500 Received: from host2.jankratochvil.net (ovpn-116-35.ams2.redhat.com [10.36.116.35]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qBDFCTDL027808 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 13 Dec 2012 10:12:32 -0500 Date: Thu, 13 Dec 2012 15:12:00 -0000 From: Jan Kratochvil To: Matt Rice Cc: Yao Qi , Mark Kettenis , gdb@sourceware.org, tromey@redhat.com Subject: Re: Will therefore GDB utilize C++ or not? Message-ID: <20121213151228.GA16752@host2.jankratochvil.net> References: <20120330161403.GA17891@host2.jankratochvil.net> <87aa2rjkb8.fsf@fleche.redhat.com> <4F8FD047.6030702@codesourcery.com> <20121204141708.GA28600@host2.jankratochvil.net> <201212041444.qB4EiG4L025312@glazunov.sibelius.xs4all.nl> <20121204145144.GA30509@host2.jankratochvil.net> <50C1EE0B.3040905@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00051.txt.bz2 On Tue, 11 Dec 2012 07:25:33 +0100, Matt Rice wrote: > On Fri, Dec 7, 2012 at 5:24 AM, Yao Qi wrote: > > How do you change the source tree? > > I create a git branch for each type of error message which gets > rebased, could you provide some small preview of the work? I would like to prevent the case of 64-bit offsets were weeks/months of work were invested to find in the end it is not well reviewable==usable. On archer-ratmice-compile-Wc++-compat where the current trunk is b68c4be8e0c1236639c6e5fc98c6894a746dde4e (from 2010) I have found the last FSF GDB merge was from e884cc5b62f170280dd49a35793bb516d95e7d8d and while trying to /usr/bin/cmp a stripped binary (which does not match) I have found this change: -void * -grow_vect (void *vect, size_t *size, size_t min_size, int element_size) +void +grow_vect (gdb_byte **vect, size_t *size, size_t min_size, int element_size) [...] - vect = xrealloc (vect, *size * element_size); + *vect = (gdb_byte *) xrealloc (*vect, *size * element_size); } - return vect; } which while (probably) correct I find it outside of the scope of this branch, making it more difficult to verify. BTW I was using ad hoc objdump -d --no-show-raw-insn gdb >1 objdump -d --no-show-raw-insn gdb >2 /usr/bin/diff -u [12] | vim - and there /^ .*\n .*\n .*\n .*\n .*\n .*\n to find: 72e351: mov -0x8(%rbp),%rax - 72e355: mov (%rax),%rax - 72e358: mov %rdx,%rsi - 72e35b: mov %rax,%rdi - 72e35e: callq 48ead0 + 72e355: mov %rdx,%rsi + 72e358: mov %rax,%rdi + 72e35b: callq 48ead0 Thanks, Jan