From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29431 invoked by alias); 14 Aug 2014 13:29:46 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 29405 invoked by uid 89); 14 Aug 2014 13:29:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 13:29:37 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 64A6C1162C7; Thu, 14 Aug 2014 09:29:35 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Sjk1pyzeuvOm; Thu, 14 Aug 2014 09:29:35 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 33B941162AC; Thu, 14 Aug 2014 09:29:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0C518493CB; Thu, 14 Aug 2014 06:29:39 -0700 (PDT) Date: Thu, 14 Aug 2014 13:29:00 -0000 From: Joel Brobecker To: Gary Benson Cc: Mike Frysinger , gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140814132939.GH4924@adacore.com> References: <20140814083231.GA6283@blade.nx> <6036430.RnprRWgZmF@vapier> <20140814131206.GA12746@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140814131206.GA12746@blade.nx> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00025.txt.bz2 > Do you mean #4 (changelog entries with no path/author-date) or are you > proposing new option #5 (no changelog in the commit message at all)? > #5 would suit me too. No, I strongly object to #5. The ChangeLog entries are part of the email to be sent along with the patch to be reviewed, We had that discussion many many years ago, and at the time, people wanted the CL entry in the email, rather than as a diff. Also, having the CL entry as a diff means maintaining that diff over time, which is guaranteed to be a source of conflicts. I know there are tools out there to deal with this specific source of conflict, but I don't think we should require everyone to set that up. And finally, I find the CL entry to be useful to have when I review revision logs. -- Joel