From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24616 invoked by alias); 18 Aug 2014 15:05:17 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 24583 invoked by uid 89); 18 Aug 2014 15:05:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 18 Aug 2014 15:05:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3D510116350; Mon, 18 Aug 2014 11:05:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rUyG1M8qEJxv; Mon, 18 Aug 2014 11:05:13 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3379D1162CF; Mon, 18 Aug 2014 11:05:12 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E4440410E0; Mon, 18 Aug 2014 17:05:10 +0200 (CEST) Date: Mon, 18 Aug 2014 15:05:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Gary Benson , Mike Frysinger , gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140818150510.GB4828@adacore.com> References: <20140814131206.GA12746@blade.nx> <20140814132939.GH4924@adacore.com> <20140815084819.GB30130@blade.nx> <20140815121102.GB6019@adacore.com> <20140815130913.GA1954@blade.nx> <20140815132816.GC6019@adacore.com> <20140815150202.GA5674@blade.nx> <20140815160829.GF6019@adacore.com> <20140818083110.GA18549@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00062.txt.bz2 > > I'm happy with this. Do you want the "ChangeLog" in the path? > > Me too. > > As for ChangeLog in the path, > Do you mean prepending entries with "gdb/ChangeLog" or > "testsuite/ChangeLog" instead of just "gdb/" or "testsuite/" ? > If so, I would say skip "ChangeLog", keep just, e.g., "testsuite/". > That's the existing convention. FWIW, I think that the extra "ChangeLog" bring 2 benefits: - it makes it clear we're starting a ChangeLog entry: - it reduces the chances of a false-positive when parsing the revision log for one or more CL entries. I found this out while developing a parser that I use in the context of the gdb release. Small bonus: When you modify the root ChangeLog file, the entry ends up looking like this... | ChangeLog: | | * file: description. ... instead of ... | : | | * file: description. ... or maybe ... | / | | * file: description. -- Joel