From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29656 invoked by alias); 16 Sep 2014 09:31:34 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 29563 invoked by uid 89); 16 Sep 2014 09:31:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 16 Sep 2014 09:31:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8G9VMDM032250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 Sep 2014 05:31:23 -0400 Received: from blade.nx (ovpn-116-123.ams2.redhat.com [10.36.116.123]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8G9VLrg026039; Tue, 16 Sep 2014 05:31:21 -0400 Received: by blade.nx (Postfix, from userid 1000) id BC9682640D5; Tue, 16 Sep 2014 10:31:20 +0100 (BST) Date: Tue, 16 Sep 2014 09:31:00 -0000 From: Gary Benson To: Doug Evans Cc: Joel Brobecker , Pedro Alves , gdb , Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140916093120.GA32511@blade.nx> References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> <54102ED8.7060307@redhat.com> <20140910162853.GT13931@adacore.com> <20140915102949.GC13503@blade.nx> <20140915160545.GN4962@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00059.txt.bz2 Doug Evans wrote: > On Mon, Sep 15, 2014 at 9:05 AM, Joel Brobecker wrote: > > > There's still something missing (IIUC). > > > One of the problems that needs to be solved is documenting the > > > author in the patch submission (the email that goes to the > > > list). The above convention allows for a default where the > > > absence of a name means author == committer, but we're still not > > > specifying an absolute requirement that the patch author appears > > > in the email sent to the list. > > > Am I missing something? > > > > I am not sure I understand what you are trying to say: You are now > > establishing that there are 3 users, not 2. author, submitter, and > > committer. Why do we need the submitter's name in the revision > > log? > > We don't need the submitter's name in the revision log. I was > referring to the patch author appearing in the email sent to the > list. > > Pedro wrote "I think author info must be explicit in patch submissions > somehow." > ref: https://sourceware.org/ml/gdb/2014-09/msg00038.html > Read the full text of 00038 for more context. > > I agree. > > The changes specified in > https://sourceware.org/ml/gdb/2014-09/msg00052.html > do not address this, yet in the text of that email (00052) > Pedro's comment is included (again, ref: 00052). We inline the ChangeLog entries in the patch submission emails, eg https://sourceware.org/ml/gdb-patches/2014-09/msg00286.html so the optional author lines would be inlined right there. Cheers, Gary -- http://gbenson.net/