From: Alan Modra <amodra@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Binutils <binutils@sourceware.org>, gdb@sourceware.org
Subject: Re: sim
Date: Thu, 11 Feb 2016 03:17:00 -0000 [thread overview]
Message-ID: <20160211031711.GA10888@bubble.grove.modra.org> (raw)
In-Reply-To: <D1AA69AC-E460-42A3-8E4F-EC1EF061717C@comcast.net>
On Wed, Feb 10, 2016 at 06:16:24PM -0800, Mike Stump wrote:
> I imported master, and got a few warnings:
>
> ./../../binutils/sim/cyclops1/../common/sim-profile.c: In function ‘profile_pc_init’:
> ../../../binutils/sim/cyclops1/../common/sim-profile.c:566:4: warning: left shift count >= width of type [enabled by default]
> ((1 << sizeof (sim_cia) * (8 - 1))
> ^
Hmm, that looks like wrong parens too. The shift count is probably
supposed to be (sizeof (sim_cia) * 8 - 1).
> ../../../binutils/sim/cyclops1/../common/sim-profile.c:585:3: warning: left shift count >= width of type [enabled by default]
> bucket_size = ((1 << ((sizeof (sim_cia) * 8) - 1))
> ^
>
> Possibly 1L might work better.
Yes, and possibly better reported to gdb. :)
--
Alan Modra
Australia Development Lab, IBM
parent reply other threads:[~2016-02-11 3:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <D1AA69AC-E460-42A3-8E4F-EC1EF061717C@comcast.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160211031711.GA10888@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb@sourceware.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).