From: Dave Martin <Dave.Martin@arm.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"gdb@sourceware.org" <gdb@sourceware.org>,
"Will Deacon" <Will.Deacon@arm.com>,
"Zhang Lei" <zhang.lei@jp.fujitsu.com>,
"Julien Grall" <Julien.Grall@arm.com>,
"Catalin Marinas" <Catalin.Marinas@arm.com>, nd <nd@arm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/2] arm64/sve: Fix mutating register endianness on big-endian
Date: Tue, 11 Jun 2019 16:25:00 -0000 [thread overview]
Message-ID: <20190611162520.GO28398@e103592.cambridge.arm.com> (raw)
In-Reply-To: <207E140D-AC57-4B0D-B838-94B92BE2B0A0@arm.com>
On Tue, Jun 11, 2019 at 04:16:11PM +0000, Alan Hayward wrote:
>
>
> > On 7 Jun 2019, at 16:48, Dave Martin <Dave.Martin@arm.com> wrote:
> >
> > On Fri, Jun 07, 2019 at 10:38:58AM +0100, Will Deacon wrote:
> >> On Thu, Jun 06, 2019 at 05:44:53PM +0100, Dave Martin wrote:
> >>> By inspection while debugging something else, I noticed that the byte
> >>> order of FPSIMD V-register stores and SVE Z-register stores is not the
> >>> same when running on big-endian.
> >>>
> >>> This is not properly taken into account when moving between the FPSIMD
> >>> and SVE register views inside the kernel, resulting in the bytes of a
> >>> V-register getting spontaneously reversed in some situations, from
> >>> userspace's point of view. The signal frame and ptrace interface are
> >>> also affected. The KVM ABI forbids mixing the two views and so should
> >>> not be affected.
> >>>
> >>> See patch 2 for details.
> >>>
> >>> Patch 1 does some trivial preparatory refactoring.
> >>
> >> Sorry to be a pain, but would you be able to flip this series round so that
> >> the fix doesn't depend on the refactoring, please? That way we can put it
> >> into stable without the dependency.
> >>
> >>> gdb may or may not be affected by this, depending on how it uses the
> >>> NT_PRFPREG and NT_ARM_SVE regsets. I'll leave it to the developers to
> >>> assess that.
> >>
> >> Wouldn't this be easy enough to test?
> >
> > So, gdb works OK on big-endian but weird stuff happening on both with
> > and without the fix.
> >
> > There are places in the gdb code itself where it is likely missing
> > endianness conversions, but I need to follow up with the gdb folks to
> > clarify whether my patch is missing somethingâ¦
>
> (I added the SVE support for GDB).
>
> Iâve tried these changes out myself using GDB.
> With your changes everything looks good, apart from:
> * GDB gets it wrong when the ptrace sve structure contains a fpsimd.
> * I need to do some testing around sigcontexts, but again I think GDB
> will need a slight change.
> Iâll get some patches together for GDB.
>
>
> > The ptrace change is theoretically an ABI break, but since the current
> > behaviour is obviously wrong, I consider this a fix.
>
> Iâm happy with this change from GDB's side.
OK, thanks for confirming.
Cheers
---Dave
next prev parent reply other threads:[~2019-06-11 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 16:45 Dave Martin
2019-06-06 16:45 ` [PATCH 1/2] arm64/sve: Factor out FPSIMD to SVE state conversion Dave Martin
2019-06-06 16:45 ` [PATCH 2/2] arm64/sve: Fix missing SVE/FPSIMD endianness conversions Dave Martin
2019-06-07 9:39 ` [PATCH 0/2] arm64/sve: Fix mutating register endianness on big-endian Will Deacon
2019-06-07 15:48 ` Dave Martin
2019-06-11 16:16 ` Alan Hayward
2019-06-11 16:25 ` Dave Martin [this message]
2019-06-12 10:40 ` Alex Bennée
2019-06-12 10:59 ` Alan Hayward
2019-06-12 12:47 ` Dave Martin
2019-06-12 13:18 ` Alex Bennée
2019-06-12 13:50 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611162520.GO28398@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=Alan.Hayward@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Julien.Grall@arm.com \
--cc=Will.Deacon@arm.com \
--cc=alex.bennee@linaro.org \
--cc=gdb@sourceware.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nd@arm.com \
--cc=peter.maydell@linaro.org \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).