From: Shahab Vahedi <shahab.vahedi@gmail.com>
To: gdb-patches@sourceware.org
Cc: gdb@sourceware.org, Shahab Vahedi <shahab@synopsys.com>,
Claudiu Zissulescu <claziss@synopsys.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: [PATCH] GDB: Fix the overflow in addr_is_displayed()
Date: Sat, 04 Jan 2020 11:43:00 -0000 [thread overview]
Message-ID: <20200104114312.165656-1-shahab.vahedi@gmail.com> (raw)
From: Shahab Vahedi <shahab@synopsys.com>
In a corner case scenario, where the height of the assembly TUI is
bigger than the number of instructions in the whole program, GDB
dumps core. The problem roots in this condition check:
int i = 0;
while (i < content. size() - threshold ...) {
... content[i] ...
}
"threshold" is 2 and there are times that "content. size()" is 0.
This results into an overflow and the loop is entered whereas it
should have been skipped.
This has been discussed at length in bug 25345:
https://sourceware.org/bugzilla/show_bug.cgi?id=25345
gdb/ChangeLog:
2020-01-04 Shahab Vahedi <shahab@synopsys.com>
* tui/tui-disasm.c (tui_disasm_window::addr_is_displayed):
Treat "content.size()" as "int" to avoid overflow.
---
gdb/tui/tui-disasm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index c72b50730b0..a0921eb09d1 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -349,10 +349,10 @@ bool
tui_disasm_window::addr_is_displayed (CORE_ADDR addr) const
{
bool is_displayed = false;
- int threshold = SCROLL_THRESHOLD;
+ int nr_of_lines = int(content.size()) - int(SCROLL_THRESHOLD);
int i = 0;
- while (i < content.size () - threshold && !is_displayed)
+ while (i < nr_of_lines && !is_displayed)
{
is_displayed
= (content[i].line_or_addr.loa == LOA_ADDRESS
--
2.24.1
next reply other threads:[~2020-01-04 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 11:43 Shahab Vahedi [this message]
2020-01-06 0:30 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104114312.165656-1-shahab.vahedi@gmail.com \
--to=shahab.vahedi@gmail.com \
--cc=claziss@synopsys.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).