From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id E846F385BF83 for ; Tue, 14 Apr 2020 11:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E846F385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=brasko.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=bob@brasko.net Received: by mail-qk1-x72a.google.com with SMTP id y3so12695870qky.8 for ; Tue, 14 Apr 2020 04:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasko-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7SZJ/VTfFFV8Dyu7KnWWYpMsyfjWjM8x0mYM9WDObnw=; b=WPji0EKgvRB0MWuGJ+lMrPMecFdMmIT+rvL8+cfdKpfYu2JhJLorZOMtmiBU3nFS+7 aCwYLz1ZRL5JwopzcyXPdFu9Y9W5Vg/m7Qw2krZhV3jZA0/xIBbwRKg+y6KNCxRwpYvv tEtkcg0T+wTke8BXGKjXAgP4CGw941PfibaDsJ23NWkBuNCuFMS4NIvIdmSMtlZ3BuD5 UX02L1cd9pdx0+VlMKGKgys3PAdKwaADWV83oWBrYH/mF4OxpvMRKOlLokEq0VNew0SO lVqFs/jcnZnKO0pKqs9jaScAiuStkbefhhLAhLL8cAocKsjapwg7mjdE1aAK+g4lH2HC Hjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7SZJ/VTfFFV8Dyu7KnWWYpMsyfjWjM8x0mYM9WDObnw=; b=JYDs84etxKKTxWya9fM+kEhYdqI2+mpAG0kILQ9FJoiybOTx4BjWs8ixqd1bBLFqt3 Xm+sUfZR75rvAEJVBDJcXn2ZGlgCrKerBrZrof+Bud056WbmCCQ/g3GU8aPWV8Nfh2WQ I/EIKRl0thHDiqApQHImMr53FPpc+8H1SFxxoVhmIwsJ4cZ/olo6I3zwBMfUtGB3nNPh WOhpHKgRYUlUTBVHGd0k3cFDcp5RPF3LBcJR/MuJZQ2Xa4jDcQr1r/8OM9cVvEeeiPbf ZroMO8Xr96MzlIK7E45xQcEodX/+RM4vq+XPNXxw28vBNfu0xvyUx23KSJbuTLps8OX8 SBjA== X-Gm-Message-State: AGi0PuYfveX+wmPIomUw9tJMaRwXGgSHDqlYVQSLmN85pkIqT+6SfJzy KKpgxVVwVT0e3Lktp81km/bqPHwC7vA= X-Google-Smtp-Source: APiQypJWkIFO1/MseaSl33+xqfSUZsEL16CjphQciECbMQYy176Jfdn1eUwt+V0pnT4Fxlacf1lwSQ== X-Received: by 2002:a05:620a:15a3:: with SMTP id f3mr19035047qkk.15.1586863386386; Tue, 14 Apr 2020 04:23:06 -0700 (PDT) Received: from xubuntu.brasko.net (pool-96-253-36-110.prvdri.fios.verizon.net. [96.253.36.110]) by smtp.gmail.com with ESMTPSA id o5sm10073559qkh.77.2020.04.14.04.23.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2020 04:23:05 -0700 (PDT) Date: Tue, 14 Apr 2020 07:23:04 -0400 From: Bob Rossi To: gdb@sourceware.org Subject: Re: source annotation now prints source line Message-ID: <20200414112304.GB22764@xubuntu.brasko.net> References: <20200404235424.GB5321@xubuntu.brasko.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200404235424.GB5321@xubuntu.brasko.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 11:23:08 -0000 On Sat, Apr 04, 2020 at 07:54:24PM -0400, Bob Rossi wrote: > When the source annotation is sent to the front end, the source line > is now also sent to the front end console. I believe this commit > introduced it, > https://github.com/bminor/binutils-gdb/commit/ec8e2b6d3051f0b4b2a8eee9917898e95046c62f > > Now CGDB displays, > (gdb) n > 43 int i = 3; > (gdb) > > Instead of, > (gdb) n > (gdb) > > CGDB is a front end, and so it has a source view to display the code to > the user. Why did GDB decide to also print the line of code to the front > end's console window as well? This is confusing. The concept behind this commit seems incorrect. The motivation for the patch isn't clearly explained in the commit message. I believe I've given a reasonable explanation on why this patch makes no sense for front ends. Should I submit a patch reverting it? Thanks, Bob Rossi