From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D015E3857819 for ; Fri, 2 Oct 2020 12:02:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D015E3857819 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-aZIrWoYaM8qO9wY8r3PmKw-1; Fri, 02 Oct 2020 08:02:36 -0400 X-MC-Unique: aZIrWoYaM8qO9wY8r3PmKw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6F72101E57F for ; Fri, 2 Oct 2020 12:02:35 +0000 (UTC) Received: from blade.nx (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTP id 786425DA74 for ; Fri, 2 Oct 2020 12:02:35 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id CE31C816CD2E; Fri, 2 Oct 2020 13:02:33 +0100 (BST) Date: Fri, 2 Oct 2020 13:02:33 +0100 From: Gary Benson To: gdb@sourceware.org Subject: Bugs in gdb/testsuite/{README,Makefile.in} Message-ID: <20201002120233.GB14696@blade.nx> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 12:02:39 -0000 Hi all, Some but not all of the check* rules in gdb/testsuite/Makefile.in have dependencies on site.exp, but all of them probably should have. This means the following will succeed if $RULE is "check", for example, but fail if $RULE is "check-parallel-racy", and probably others too: mkdir build cd build ../src/configure ... make cd gdb/testsuite make $RULE I've fixed this manually in my setup, by running 'make site.exp' under gdb/testsuite. I found 'make site.exp' mentioned in gdb/testsuite/README, but only indirectly: the README file says you can either run make check from the toplevel build directory, or you can cd into gdb/testsuite and use runtest after "make site.exp". Probably that part of gdb/testsuite/README should also mention that you can use "make check*" under gdb/testsuite too. Probably also, the check* rules that don't depend on site.exp should have a dependency added. I don't have time to fix either at present, so I'm not volunteering! Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat