From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 1DBE03857C7F for ; Sun, 1 Nov 2020 06:04:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1DBE03857C7F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E92AE117C74 for ; Sun, 1 Nov 2020 01:04:54 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gW8Cn35N9ZYy for ; Sun, 1 Nov 2020 01:04:54 -0500 (EST) Received: from float.home (localhost.localdomain [127.0.0.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPS id 8D1E7117A4C for ; Sun, 1 Nov 2020 01:04:54 -0500 (EST) Received: by float.home (Postfix, from userid 1000) id A0E68A1883; Sun, 1 Nov 2020 10:04:49 +0400 (+04) Date: Sun, 1 Nov 2020 10:04:49 +0400 From: Joel Brobecker To: gdb@sourceware.org Subject: Re: FTR: this GDB patch is AdaCore-local (R907-036: do not suppress all symbols in the STRUCT_DOMAIN) Message-ID: <20201101060449.GA1860282@adacore.com> References: <20201101060130.GA1859832@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101060130.GA1859832@adacore.com> X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2020 06:04:56 -0000 And this is, children, the reason why one should never work on weekends :-(. I apologize for the noise. > Just recording the fact that the following patch... > > | commit 0bf64e2236bd6a2aacb978e5a7fa0a5b43567665 > | Subject: (Ada) do not suppress all symbols in the STRUCT_DOMAIN > | Author: Joel Brobecker > | Date: 2018-09-25 14:52:01 -0700 > | Subject: (Ada) do not suppress all symbols in the STRUCT_DOMAIN > > cannot be contributed upstream, because it touches a function > (ada_suppress_symbol_printing) which is specific to the AdaCore > version of GDB. > > This is from memory, but I believe we tried to contribute this function > (combined with its companion function called is_suppressed_name), and > got feedback that we should be doing it differently, relying on DWARF > rather than GNAT encodings to determine whether symbols should be > displayed or not. > > I will annotate the commit accordingly. -- Joel