From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id C391038207E7; Wed, 8 Jun 2022 18:52:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C391038207E7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x09.wildebeest.org [172.31.17.139]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id D89D33000B37; Wed, 8 Jun 2022 20:52:02 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 5B56F2E83DB0; Wed, 8 Jun 2022 20:51:46 +0200 (CEST) From: Mark Wielaard To: buildbot@sourceware.org Cc: gdb@sourceware.org, Mark Wielaard Subject: [builder] gdb_check_step: remove gdb.gdb/selftest.exp Date: Wed, 8 Jun 2022 20:51:38 +0200 Message-Id: <20220608185138.675964-1-mark@klomp.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 18:52:06 -0000 Hi, I just committed the following update to builder: selftest.exp is bad (flaky), just keep the gdb and gdbserver unittest.exp for the CI runs. builder.sourceware.org does two builds for gdb. quick CI builds that just build gdb and gdb-server and run a small amount of tests that are known to reliably PASS. If any of this fails it will sent email to the gdb-testers mailinglist and the author of the commit. https://builder.sourceware.org/buildbot/#/builders?tags=gdb It also does full builds for binutils-gdb as a whole plus the full testsuite both against gcc and clang. These do record all logs in bunsendb but doesn't sent emails: https://builder.sourceware.org/buildbot/#/builders?tags=binutils-gdb With the removal of the selftest.exp there are only two unittest.exp tests (one for gdb and one for gdbserver). This does seem very minimal. Could someone suggest stable, known good passing tests that should be added because when they do start failing it really is a regression that should be flagged? Note that the intention is to also allow a trybot that runs the same set of CI tests so it can be used as pre-commit check. Cheers, Mark P.S. There were same bad failing emails today. Our apologies, that was a bunsen upload typo. --- builder/master.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/builder/master.cfg b/builder/master.cfg index 852322f..af4f65f 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -1446,7 +1446,6 @@ gdb_check_step = steps.Test( util.Interpolate('-j%(prop:ncpus)s'), 'check-gdb', ("TESTS= " - "gdb.gdb/selftest.exp " "gdb.gdb/unittest.exp " "gdb.server/unittest.exp ")], name='make check-gdb', -- 2.30.2