From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [188.68.32.151]) by sourceware.org (Postfix) with ESMTPS id 04F663858D28; Fri, 3 Mar 2023 21:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04F663858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id 3672342073; Fri, 3 Mar 2023 22:27:58 +0100 (CET) Date: Fri, 3 Mar 2023 22:27:58 +0100 From: Jan-Benedict Glaw To: Mike Frysinger Cc: gdb-patches@sourceware.org, gdb@sourceware.org, joel@rtems.org Subject: Re: [PATCH] sim: mips/ppc/riscv: re-add AC_CANONICAL_SYSTEM [PR sim/29439] Message-ID: <20230303212758.jeukghx7kmxhn6cx@lug-owl.de> References: <20221023171147.12371-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="54arp33ngrpyheok" Content-Disposition: inline In-Reply-To: <20221023171147.12371-1-vapier@gentoo.org> X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --54arp33ngrpyheok Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, 2022-10-23 22:56:47 +0545, Mike Frysinger via Gdb-patches wrote: > These configure scripts check $target and change behavior. They > shouldn't be doing that, but until we can rework the sim to change > behavior based on the input ELF, restore AC_CANONICAL_SYSTEM to > these so that $target is correctly populated. >=20 > This was lost in the d3562f83a7b8a1ae6e333cd5561419d3da18fcb4 > ("sim: unify toolchain probing logic") refactor as the logic was > hoisted up to the common code. But the fact the vars weren't > passed down to the sub-configure scripts was missed. >=20 > Bug: https://sourceware.org/PR29439 This fix seems to have a side effect: =2E../configure --prefix=3D/tmp/gdb-mipsisa64sb1-elf --target=3Dmipsisa64sb= 1-elf make V=3D1 all-gdb [...] [all 2023-03-03 21:07:56] /usr/lib/gcc-snapshot/bin/gcc -DHAVE_CONFIG_H -D= WITH_TARGET_WORD_BITSIZE=3D64 -DWITH_TARGET_WORD_MSB=3D63 -DWITH_FLOATING_P= OINT=3DHARD_FLOATING_POINT -DWITH_TARGET_FLOATING_POINT_BITSIZE=3D64 -DWITH= _HW=3D1 -DHAVE_DV_SOCKSER -DDEFAULT_INLINE=3D0 -Wall -Wdeclaration-after-st= atement -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-s= witch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wno-err= or=3Dmaybe-uninitialized -Wmissing-declarations -Wmissing-prototypes -Wdecl= aration-after-statement -Wmissing-parameter-type -Wpointer-sign -Wold-style= -declaration -Werror -I. -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/bi= nutils-gdb/sim/mips -I../common -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf= /51/binutils-gdb/sim/mips/../common -I../../include -I/var/lib/laminar/run/= gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../include -I../../bfd -I/= var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gdb/sim/mips/../../bfd= -I../../opcodes -I/var/lib/laminar/run/gdb-mipsisa64sb1-elf/51/binutils-gd= b/sim/mips/../../opcodes -I../.. -I/var/lib/laminar/run/gdb-mipsisa64sb1-e= lf/51/binutils-gdb/sim/mips/../../gnulib/import -I../../gnulib/import -DTAR= GET_ENABLE_FR=3D1 -DMIPS_MACH_DEFAULT=3Dbfd_mach_mips_sb1 -g -O2 -c -o se= mantics.o -MT semantics.o -MMD -MP -MF .deps/semantics.Tpo semantics.c [all 2023-03-03 21:07:56] sb1.igen: In function 'semantic_PABSDIFC_fmt_MDMX= ': [all 2023-03-03 21:07:56] sb1.igen:178:21: error: unknown conversion type c= haracter 'v' in format [-Werror=3Dformat=3D] [all 2023-03-03 21:07:56] 178 | check_mdmx (SD_, instruction_0); [all 2023-03-03 21:07:56] | ^~~~~~~~~~~~~~ = =20 [all 2023-03-03 21:07:56] sb1.igen:178:21: error: format '%ld' expects argu= ment of type 'long int', but argument 9 has type 'unsigned int' [-Werror=3D= format=3D] [all 2023-03-03 21:07:56] 178 | check_mdmx (SD_, instruction_0); [all 2023-03-03 21:07:56] | ^~~~~~~~~~~~~~ = =20 [all 2023-03-03 21:07:56] sb1.igen:178:21: error: too many arguments for fo= rmat [-Werror=3Dformat-extra-args] [all 2023-03-03 21:08:05] cc1: all warnings being treated as errors Sorry for taking so long to report it. MfG, JBG --=20 --54arp33ngrpyheok Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZAJmVQAKCRAdvV51g5nh u24TAJ4p1mggAX8NV8a+PQef6ehpHbw25QCeOFvDIko8aB3dSmL7QZOQHulS5iQ= =N28M -----END PGP SIGNATURE----- --54arp33ngrpyheok--