From: Luis Machado <luis.machado@arm.com>
To: Mark Wielaard <mark@klomp.org>, buildbot@sourceware.org
Cc: gdb@sourceware.org
Subject: Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp
Date: Thu, 9 Jun 2022 10:37:58 +0100 [thread overview]
Message-ID: <2281be8e-8920-7ba5-9e96-ffd713462b9c@arm.com> (raw)
In-Reply-To: <20220608185138.675964-1-mark@klomp.org>
On 6/8/22 19:51, Mark Wielaard wrote:
> Hi,
>
> I just committed the following update to builder:
>
> selftest.exp is bad (flaky), just keep the gdb and gdbserver
> unittest.exp for the CI runs.
>
> builder.sourceware.org does two builds for gdb. quick CI builds that
> just build gdb and gdb-server and run a small amount of tests that are
> known to reliably PASS. If any of this fails it will sent email to the
> gdb-testers mailinglist and the author of the commit.
> https://builder.sourceware.org/buildbot/#/builders?tags=gdb
>
> It also does full builds for binutils-gdb as a whole plus the full
> testsuite both against gcc and clang. These do record all logs in
> bunsendb but doesn't sent emails:
> https://builder.sourceware.org/buildbot/#/builders?tags=binutils-gdb
>
> With the removal of the selftest.exp there are only two unittest.exp
> tests (one for gdb and one for gdbserver). This does seem very
> minimal. Could someone suggest stable, known good passing tests that
> should be added because when they do start failing it really is a
> regression that should be flagged?
>
> Note that the intention is to also allow a trybot that runs the same
> set of CI tests so it can be used as pre-commit check.
>
> Cheers,
>
> Mark
>
> P.S. There were same bad failing emails today. Our apologies, that was
> a bunsen upload typo.
>
> ---
> builder/master.cfg | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/builder/master.cfg b/builder/master.cfg
> index 852322f..af4f65f 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -1446,7 +1446,6 @@ gdb_check_step = steps.Test(
> util.Interpolate('-j%(prop:ncpus)s'),
> 'check-gdb',
> ("TESTS= "
> - "gdb.gdb/selftest.exp "
> "gdb.gdb/unittest.exp "
> "gdb.server/unittest.exp ")],
> name='make check-gdb',
I always use gdb.base/break.exp as a good smoke test. If that one fails, then things
are really broken.
I think gdb.base/break*.exp should make a good smoke test list. We just need to exclude
gdb.base/break-interp.exp, which is problematic on some targets.
If you also want to exercise gdbserver, then run with native-gdbserver and native-extended-gdbserver
boards. For example:
make check-gdb TESTS="gdb.base/break*.exp" RUNTESTFLAGS="--target_board=native-gdbserver" -j$(nproc).
next prev parent reply other threads:[~2022-06-09 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 18:51 Mark Wielaard
2022-06-09 9:37 ` Luis Machado [this message]
2022-06-09 23:09 ` Mark Wielaard
2022-06-09 23:21 ` Mark Wielaard
2022-06-10 10:50 ` Mark Wielaard
2022-06-10 10:58 ` Luis Machado
2022-06-10 15:17 ` will schmidt
2022-06-10 15:54 ` Carl Love
2022-06-10 19:11 ` Mark Wielaard
2022-06-10 20:11 ` Carl Love
2022-06-10 22:23 ` Frank Ch. Eigler
2022-06-29 15:58 ` Carl Love
2022-06-29 22:42 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2281be8e-8920-7ba5-9e96-ffd713462b9c@arm.com \
--to=luis.machado@arm.com \
--cc=buildbot@sourceware.org \
--cc=gdb@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).