From: Tristan Gingold <gingold@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Jack Howarth <howarth@bromo.med.uc.edu>, gdb@sourceware.org
Subject: Re: PR13901
Date: Mon, 02 Apr 2012 14:25:00 -0000 [thread overview]
Message-ID: <2FC589F0-E66A-4464-A93D-D8F532B24917@adacore.com> (raw)
In-Reply-To: <4F79B4CB.4090903@redhat.com>
On Apr 2, 2012, at 4:16 PM, Pedro Alves wrote:
> On 04/02/2012 03:06 PM, Tristan Gingold wrote:
>
>>
>> On Apr 2, 2012, at 3:56 PM, Pedro Alves wrote:
>
>
>>> Why does GDB need to touch the shell's registers at all in the first place?
>>
>> I haven't checked why.
>
>
> Well, I claim that it shouldn't. :-) The whole existence of
> fork-child.c:startup_inferior was justified on making GDB not touch the
> shell. We used to have the startup phase go through the whole
> wait_for_inferior shebang, which was problematic as it touched the shell.
>
>>
>>> If we can't skip darwin_set_sstep for all continues that are not single-steps,
>>> we could at least skip those while starting up (when continuing the shell
>>> until we see enough execs). That'd suggest a new flag like
>>> darwin-nat.h:struct private_inferior->starting_up, set and cleared in
>>> darwin_create_inferior, and then making darwin_resume_thread do:
>>>
>>> - /* Set single step. */
>>> - inferior_debug (4, _("darwin_set_sstep (thread=%x, enable=%d)\n"),
>>> - thread->gdb_port, step);
>>> - darwin_set_sstep (thread->gdb_port, step);
>>> + /* Avoid touching the $SHELL process, and go straight to resuming it. */
>>> + gdb_assert (!inf->private->starting_up || !step);
>>> + if (!inf->private->starting_up)
>>> + {
>>> + /* Set single step. */
>>> + inferior_debug (4, _("darwin_set_sstep (thread=%x, enable=%d)\n"),
>>> + thread->gdb_port, step);
>>> + darwin_set_sstep (thread->gdb_port, step);
>>>
>>> WDYT?
>>
>> Yes, it might be cleaner.
>>
>> Honestly, I'd prefer to get rid of the shell step and directly execute the user program - or at least have an option to do that. I think I also understand the cons of this approach.
>
>
> I'd be glad to see STARTUP_WITH_SHELL turned into a run-time option.
Good to know that.
> I think there's
> a PR open for that even. However, we need the shell at least for argument globbing,
> as in, e.g., debugging `ls *', so I don't think we could make it off by default,
> which practically renders it an orthogonal feature.
Sure.
Tristan.
next prev parent reply other threads:[~2012-04-02 14:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 13:42 PR13901 Jack Howarth
2012-03-30 14:19 ` PR13901 Tristan Gingold
2012-04-02 10:44 ` PR13901 Tristan Gingold
2012-04-02 11:57 ` PR13901 Tristan Gingold
2012-04-02 13:17 ` PR13901 Jack Howarth
2012-04-02 13:22 ` PR13901 Tristan Gingold
2012-04-02 13:56 ` PR13901 Pedro Alves
2012-04-02 14:07 ` PR13901 Tristan Gingold
2012-04-02 14:17 ` PR13901 Pedro Alves
2012-04-02 14:25 ` Tristan Gingold [this message]
2012-04-02 14:59 ` PR13901 Andreas Schwab
2012-04-02 15:08 ` PR13901 Tristan Gingold
2012-04-02 15:23 ` PR13901 Pedro Alves
2012-04-02 16:22 ` PR13901 Andreas Schwab
2012-04-02 16:31 ` PR13901 Pedro Alves
2012-04-02 17:28 ` PR13901 Andreas Schwab
2012-04-03 7:28 ` PR13901 John Gilmore
2012-04-04 14:23 ` PR13901 Pedro Alves
2012-04-04 14:47 ` PR13901 Tristan Gingold
2012-04-04 15:01 ` PR13901 Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2FC589F0-E66A-4464-A93D-D8F532B24917@adacore.com \
--to=gingold@adacore.com \
--cc=gdb@sourceware.org \
--cc=howarth@bromo.med.uc.edu \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).