From: Simon Marchi <simon.marchi@polymtl.ca>
To: David Blaikie <dblaikie@gmail.com>
Cc: Zied Guermazi <zied.guermazi@trande.de>, gdb@sourceware.org
Subject: Re: GNU style checker for GDB
Date: Mon, 8 Mar 2021 17:53:29 -0500 [thread overview]
Message-ID: <306ba518-b507-494a-a55a-178531df05a0@polymtl.ca> (raw)
In-Reply-To: <CAENS6EsNPpJOog5w0xU9xgvC7REn56GaAX=WkGTQk57sn1+Qfw@mail.gmail.com>
On 2021-03-08 5:39 p.m., David Blaikie wrote:
>
>
> On Mon, Mar 8, 2021 at 2:31 PM Simon Marchi <simon.marchi@polymtl.ca <mailto:simon.marchi@polymtl.ca>> wrote:
>
> On 2021-03-08 3:39 p.m., David Blaikie wrote:
> > If anyone's interested in investing some time in it, I expect clang-format would be open to bugs/patches to support whatever formatting idioms gdb needs.
>
> That's one of those things I'd really like to try, but will never have
> time. But I can at least file some bugs.
>
> What stopped me from doing so in the past is that the missing things
> were really some things I would consider like oddities / inconsistency
> of our style. For example, we use space before parenthesis, except for
> the `_` (gettext) macro:
>
> printf (_("Hello %s\n"), name);
>
> If we tell clang-format we want spaces before function call parenthesis,
> it (rightfully) inserts a space after the `_`. To prevent that, I
> suppose we'd need a way to say: in general I want this style, but for
> this macro I want this other style. I fear I'll be called crazy if I
> request that :).
>
>
> I think if you can point to a widely used style (the gdb (& binutils more generally?) codebase) there's probably going to be a fair bit of sympathy/understanding there.
Ok, I will. Worst case, the idea is shot down.
I filed a first one here:
https://bugs.llvm.org/show_bug.cgi?id=49481
Simon
next prev parent reply other threads:[~2021-03-08 22:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 13:10 Zied Guermazi
2021-03-08 17:35 ` Simon Marchi
2021-03-08 20:39 ` David Blaikie
2021-03-08 22:31 ` Simon Marchi
2021-03-08 22:39 ` David Blaikie
2021-03-08 22:53 ` Simon Marchi [this message]
2021-03-08 23:21 ` Dave Marples
2021-03-09 6:08 ` Metzger, Markus T
2021-03-10 10:32 ` Zied Guermazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=306ba518-b507-494a-a55a-178531df05a0@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=dblaikie@gmail.com \
--cc=gdb@sourceware.org \
--cc=zied.guermazi@trande.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).