From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 21CDD3858D35 for ; Tue, 23 Nov 2021 02:33:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21CDD3858D35 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1AN2WnXp018306 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Nov 2021 21:32:54 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1AN2WnXp018306 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 46F4A1ECEB; Mon, 22 Nov 2021 21:32:49 -0500 (EST) Message-ID: <381c7713-74e5-de35-0ff2-5af1c50d1996@polymtl.ca> Date: Mon, 22 Nov 2021 21:32:48 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] gnu-nat.c: fix calls to add_info_alias Content-Language: en-US To: Andrea Monaco , gdb@sourceware.org References: <87h7cp8dae.fsf@autistici.org> From: Simon Marchi In-Reply-To: <87h7cp8dae.fsf@autistici.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 23 Nov 2021 02:32:49 +0000 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 02:33:06 -0000 On 2021-11-06 12:22, Andrea Monaco via Gdb wrote: > > Hello, > > > some time ago add_info_alias was changed (commit > e0f25bd9717c7973197095523db7c1cdc956cea2). These calls were not updated > and caused errors on compilation. > > > Warmly, > > Andrea Monaco > > > > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index c6cecff0686..2d15b3d3e58 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -3286,15 +3286,17 @@ This is the same as setting `task pause', `exceptions', and\n\ > _("Show information about the task's send rights.")); > add_info ("receive-rights", info_recv_rights_cmd, > _("Show information about the task's receive rights.")); > - add_info ("port-rights", info_port_rights_cmd, > - _("Show information about the task's port rights.")); > - add_info ("port-sets", info_port_sets_cmd, > - _("Show information about the task's port sets.")); > + cmd_list_element *port_rights_cmd = > + add_info ("port-rights", info_port_rights_cmd, > + _("Show information about the task's port rights.")); > + cmd_list_element *port_sets_cmd = > + add_info ("port-sets", info_port_sets_cmd, > + _("Show information about the task's port sets.")); > add_info ("dead-names", info_dead_names_cmd, > _("Show information about the task's dead names.")); > - add_info_alias ("ports", "port-rights", 1); > - add_info_alias ("port", "port-rights", 1); > - add_info_alias ("psets", "port-sets", 1); > + add_info_alias ("ports", port_rights_cmd, 1); > + add_info_alias ("port", port_rights_cmd, 1); > + add_info_alias ("psets", port_sets_cmd, 1); > } > > ^L > Hi, I had trouble applying your patch, I suppose the text was modified by your email client. But it is small enough that I applied it by hand and pushed it, thanks. Just note for next time that patches should ideally be sent to the gdb-patches mailing list. Simon