From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec103.isp.belgacom.be (mailsec103.isp.belgacom.be [195.238.20.99]) by sourceware.org (Postfix) with ESMTPS id 5B9A63851C07 for ; Fri, 8 May 2020 21:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B9A63851C07 IronPort-SDR: LhkX8+yLkLzwzbkYklIV9athtHKxgeeX2LgCr7fCzmU6ctm0+5eslDBcPF0Nxy922Hdb02yRNH ACq/slDnLAPpCFzn3Qz9Ziu5BkTqsTldJmkecZLBf0q0QNPzdZ63S4lzJqwJ7J7SmvF+ugsQEe JDdjXo2NrCboNdkuSyCzEh3OwgKyveUyJ3Yp0jXyyCnOYkLVfbEkGwfHIxBI5m/CfGb2tSN/7U rBr1o9N9DDjADaM+v+/dai1sTlLeA1g195Ku7Xy6UYDADKHMe1P3ZbVdD/jcrqAgZHOruNJ+Ly pzM= IronPort-PHdr: =?us-ascii?q?9a23=3Aah2nIxzeNVYX/TPXCy+O+j09IxM/srCxBDY+r6?= =?us-ascii?q?Qd0uoWKvad9pjvdHbS+e9qxAeQG9mCtrQU0KGH6ujJYi8p2d65qncMcZhBBV?= =?us-ascii?q?cuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx?= =?us-ascii?q?7xKRR6JvjvGo7Vks+7y/2+94fcbglVhDexe7B/IRu5oQjVq8UdnJdvJLs2xh?= =?us-ascii?q?bVuHVDZv5YxXlvJVKdnhb84tm/8Zt++ClOuPwv6tBNX7zic6s3UbJXAjImM3?= =?us-ascii?q?so5MLwrhnMURGP5noHXWoIlBdDHhXI4wv7Xpf1tSv6q/Z91SyHNsD4Ubw4RT?= =?us-ascii?q?Kv5LpwRRT2lCkIKSI28GDPisxxkq1bpg6hpwdiyILQeY2ZKeZycr/Ycd4cWG?= =?us-ascii?q?FPXNteVzZZD42/coUBD/QPM+haoInzu1QBoxSxCwa3CePzyDJFnGP60bEg3u?= =?us-ascii?q?kjFwzNwQwuH8gJsHTRtNj7LqcSUeGxzKnJ1TXDd+1Z0ir954fSaBAhpuiMXa?= =?us-ascii?q?9xccXP00kvDB7Og1KIqYzlPjOV0uUNs3CD7+V+T+6uhXQoqxt2oji228csi5?= =?us-ascii?q?fGhpgOyl3f7iV5w4Y0JdumR05ne9KrC4VfujicOoBrTcwsX3tmtzwmyr0ap5?= =?us-ascii?q?G7Zi4KxYw5yxLBaPGKb4eF7g7/WOuTITp1i29odrKjixu9/kauyvDxW8ew3V?= =?us-ascii?q?tUoCRIjNfBu3MO2hHd68WKSvVw80il1DuO0Q3Y9+JKIVgsmKbFNpIswKQ8mo?= =?us-ascii?q?cdvEnCBCP7m1j6gLWYe0gq/OWj9v7pba/8ppCGMo95kgT+MqMzlcOhGek4KQ?= =?us-ascii?q?0OX3SD+eS7yb3j4VX1QLVUgf0ylanUqJXaKtkDqq64BQ9azJoj5g6hAzu70t?= =?us-ascii?q?kUh2QLIVxEdR6djIXlJkvCLf72APunhlSjijZrx/TIPr37BZXNK2DOkK/hfb?= =?us-ascii?q?Z8705cyRIzzchB6J5OBLAOOujzWkjotNzFDx82LRa0w/38BdVm1YMfWWSPDb?= =?us-ascii?q?GFMK/IqlCH+PojI/OQa48NpDb9N/8l6ubrjXAjg18dfrSp3YANZHCkBPhmJl?= =?us-ascii?q?uWYWbtg9cOD2gKpBEzTO3siF2eTzFTY2y+UL475jE+EIimF5vMRpixgLyd2y?= =?us-ascii?q?e2BpJWaX1dBV2XCnfocJiEW+0QZy2MLM5uiCYEWqa7R48mzxGuu1yy970yZM?= =?us-ascii?q?/Z5j8XuIinnP18/e7OjlkOv3QgCs2H0HyWCX0ym24UVTA7xoh+p1BwzhGI1q?= =?us-ascii?q?0ux7R3OfYbs/xFWC8hMoPGxOFlAsr/HAXbcYHaZkyhR4CeATA1T8opzpcxal?= =?us-ascii?q?x6AsijgwrYl36yA74RlqSTCdor+7jbxmXwKtxm423Fxa8skx8sT50cZiWdmq?= =?us-ascii?q?dj+l2LVMbymEKDmvPvLPxE0Q=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AfAQAWzbVe/yFRiNlmGwEBAQEBAQE?= =?us-ascii?q?BBQEBARIBAQEDAwEBAUCBR4IqSStPIRKEUIkBiAo1AZsrCwEBAQEBAQEBAQg?= =?us-ascii?q?sAQIEAQGERAKCCyc4EwIDAQEBAwIFAQEGAQEBAQEBBAQBbAQBAQcKhFEhAQM?= =?us-ascii?q?BAQUKAUOCOykBgw0BBSMzMwgDGAICJgICVwYBhjmvaoEyhVKDVYFAgQ4qhSy?= =?us-ascii?q?HJ4FMP4NsNT6HYoI+IgSZF5hXfQeCTX8ElyUdnTqQHZ1SgWkigVZtgz1PJZ8?= =?us-ascii?q?KQmcCBggBAQMJdAgTinQtghYBAQ?= X-IPAS-Result: =?us-ascii?q?A2AfAQAWzbVe/yFRiNlmGwEBAQEBAQEBBQEBARIBAQEDA?= =?us-ascii?q?wEBAUCBR4IqSStPIRKEUIkBiAo1AZsrCwEBAQEBAQEBAQgsAQIEAQGERAKCC?= =?us-ascii?q?yc4EwIDAQEBAwIFAQEGAQEBAQEBBAQBbAQBAQcKhFEhAQMBAQUKAUOCOykBg?= =?us-ascii?q?w0BBSMzMwgDGAICJgICVwYBhjmvaoEyhVKDVYFAgQ4qhSyHJ4FMP4NsNT6HY?= =?us-ascii?q?oI+IgSZF5hXfQeCTX8ElyUdnTqQHZ1SgWkigVZtgz1PJZ8KQmcCBggBAQMJd?= =?us-ascii?q?AgTinQtghYBAQ?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 May 2020 23:25:07 +0200 Message-ID: <395e655e716ba5ebd90060cd467e438037f0eeb2.camel@skynet.be> Subject: Re: exec-file-mismatch and native-gdbserver testing From: Philippe Waroquiers To: "Metzger, Markus T" , GDB Date: Fri, 08 May 2020 23:25:07 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 May 2020 21:25:11 -0000 On Fri, 2020-05-08 at 10:30 +0000, Metzger, Markus T wrote: > Hello Philippe, > > > > > In exec.c:validate_exec_file (), we check the filenames and, if they differ, > > print > > > a warning and re-load the symbol file. > > > > Should validate_exec_file () check more than just the filenames? > > > You mean: if the filenames differs, gdb could compare the contents of files and > > if > > > equal, > > > not ask the question, considering there is no mismatch ? > > > > It could compare build-ids, for example. > > > > If there are no build-ids, it may fall back to comparing file contents as you > > suggested. > > Does that sound OK to you? > > Thanks, > Markus. Hello Markus, If build ids of 2 files are equal, then effectively, validate_exec_file can consider the existing file is still ok. I had however no time to dig on that, and see if such build ids can be easily extracted/retrieved in validate_exec_file. I had no time to dig more on that, sorry Philippe